Update pokecli.py #5049
Merged
Update pokecli.py #5049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check pgoapi version on startup
|
@sohje, thanks for your PR! By analyzing the annotation information on this pull request, we identified @douglascamata, @TheSavior and @mjmadsen to be potential reviewers |
|
does this check the requirements.txt for version information or pip? |
|
We dont have required version of pgoapi in requirements.txt, only commit hash. |
| print 'Seems you forgot to install python modules.' | ||
| print 'Run: `pip install -r requirements.txt`' | ||
| sys.exit(1) | ||
| except ImportError as e: |
There was a problem hiding this comment.
Is this good to bypass missing import?
There was a problem hiding this comment.
It should bypass if import pkg_resources raises ImportError.
If no pgoapi installed, then pkg_resources.DistributionNotFound should raised.
There was a problem hiding this comment.
oh, I understand. Thanks
👍
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
Check PgoApi version on bot start
Fixes/Resolves/Closes (please use correct syntax):
Check pgoapi version on startup