Fix #5051 #5055
Merged
Fix #5051 #5055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DeXtroTip, thanks for your PR! By analyzing the annotation information on this pull request, we identified @mjmadsen, @alexyaoyang and @achretien to be potential reviewers |
|
You might wanna add lower to the evolve/do_not_evolve list as well, since users may input with or without caps. |
|
@Jasperrr91 Yep, that's already on lines 31 and 34 |
|
@DeXtroTip Oh yea, I wasn't looking properly! Coffee must have worn out 🤓 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
Haven't tested it but being the problem missing an uppercase letter (dratini -> Dratini), this should fix it, since it makes all pokemon names strings lowercase before compare and test.
Fixes/Resolves/Closes (please use correct syntax):