Add CampFort task #5105
Add CampFort task #5105
Conversation
|
@anakin5, thanks for your PR! By analyzing the annotation information on this pull request, we identified @TheSavior, @jtdroste and @DeXtroTip to be potential reviewers |
| self.config_max_distance = self.config.get("max_distance", 2000) | ||
| self.config_min_forts_count = self.config.get("min_forts_count", 2) | ||
| self.config_min_lured_forts_count = self.config.get("radius", 1) | ||
| self.config_camping_time = self.config.get("radius", 1800) |
There was a problem hiding this comment.
typo? Shouldn't this be "camping_time" instead of "radius"?
There was a problem hiding this comment.
yes typo. thanks i will fix
|
This task includes many logic task here. Is there better way to struct it? |
|
What logic are you referring to ? |
| alt = self.walker.pol_alt + random_alt_delta() / 2 | ||
| self.bot.api.set_position(lat, lon, alt) | ||
| self.last_position_update = now | ||
| self.bot.heartbeat() |
There was a problem hiding this comment.
heartbeat should be call in tick.
There was a problem hiding this comment.
I will remove it. It is not needed anymore since commit 5b3cfbb.
Otherwise, if heartbeat should be called in tick, why isn't it ?
|
@anakin5 I have two inline comments |
|
I added moving_time parameter to forward movement to next task during that time. |
|
I believe @solderzzc is saying that it is not advised to use info from workers in this way as there are cases where "running" information would not be ready to read depending on which order it were in in the task list - and he also said
this look good to me 💃 |
|
Lol @BreezeRo has much better English language ability. |
|
👍 |
|
What tasks can this be combined with? What is you config for tasks #5169 |
New task that walk between fort clusters and stay there for the time configured.
max_distanceis radius in meters of the circle around starting position to limit movements of the bot.min_forts_countis the minimum number of forts to be considered a cluster.min_lured_forts_countis the minimum number of lured forts to be considered a cluster.camping_timeis the minimum time to stay at a cluster. A cluster can be selected again after if it is still the best place to be.To be place before MoveToFort