Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decouple datastore from the bot #5141

Merged
merged 1 commit into from
Sep 3, 2016
Merged

decouple datastore from the bot #5141

merged 1 commit into from
Sep 3, 2016

Conversation

rawgni
Copy link
Contributor

@rawgni rawgni commented Sep 3, 2016 •
edited
Loading

Short Description:

The Datastore is being initialized multiple times, resulting in multiple duplicate migrations.

Fixes/Resolves/Closes (please use correct syntax):

  • Initialize the Datastore once, migrate once, and done with it.
  • Pass the datastore connection to the bot.
  • Easier to mock datastore since it's no longer initialized inside PokemonGoBot()

@BreezeRo
Copy link
Contributor

BreezeRo commented Sep 3, 2016

Excellent work right here brother, please update this branch with the latest changes from dev so we can merge

@rawgni
Copy link
Contributor Author

rawgni commented Sep 3, 2016

@BreezeRo should be updated now

@solderzzc
Copy link
Contributor

Since the DB expert approval, we can have this merged.

@solderzzc solderzzc merged commit b1139dd into PokemonGoF:dev Sep 3, 2016
@rawgni rawgni deleted the datastore_init branch September 3, 2016 15:33
@rawgni rawgni restored the datastore_init branch September 3, 2016 15:33
@MZorzy
Copy link

MZorzy commented Sep 10, 2016

alt_min default 500
alt_max default 1000
alt default 8 ?

please set null and force chek exist on a config file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rawgni @BreezeRo @solderzzc @MZorzy