refactor log handler #5228
Merged
refactor log handler #5228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawgni
force-pushed
the
simpler_logging
branch
from
405038a
to
43af3a9
Compare
|
rawgni
force-pushed
the
simpler_logging
branch
from
43af3a9
to
c22f426
Compare
|
@solderzzc fixed |
rawgni
force-pushed
the
simpler_logging
branch
from
c22f426
to
2e02cd7
Compare
rawgni
force-pushed
the
simpler_logging
branch
from
2e02cd7
to
fe2b37e
Compare
|
@solderzzc any problem with this ? |
|
No, I don't think there's any, just have time to go through code... |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
refactor logging handler code.
log handler shouldn't need to have access to the whole bot, but only needed config