Fix: spawnpoint in gathered data #5352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sohje, thanks for your PR! By analyzing the annotation information on this pull request, we identified @solderzzc, @YvesHenri and @chrisle to be potential reviewers |
|
Nice. |
| pokemon['encounter_id'] = pokemon['encounter_id'] | ||
| pokemon['spawn_point_id'] = pokemon['spawn_point_id'] | ||
| pokemon['encounter_id'] = pokemon.get('encounter_id', '') | ||
| pokemon['spawn_point_id'] = pokemon.get('spawn_point_id', '') or pokemon.get('spawnpoint_id', '') |
There was a problem hiding this comment.
Why two different attrs ("spawnpoint_id" or "spawn_point_id")? Does it vary or just don't know?
There was a problem hiding this comment.
From pokemap its 'spawnpoint_id', from social - 'spawn_point_id'.
Dunno, mb in the future we will need them or remove completely.
There was a problem hiding this comment.
OK just wondering. Approving.
There was a problem hiding this comment.
I'm not sure on social though, but I'm planning to enable dynamic param name mapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
Fix issues with incorrect spawnpoint_id in gathered data