Python 3 Compatibility #5490
Merged
Python 3 Compatibility #5490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: pokemongo_bot/cell_workers/transfer_pokemon.py
Conflicts: pokemongo_bot/cell_workers/transfer_pokemon.py
|
👍 There're many files changes, we should better merge first before others to get rid of conflict. |
|
pylint run in a python 3 virtual environment will check using Py3's formatting. Not sure about running them side by side |
|
From searching, it's easier to add version number in the .travis.yml, need check if works as expect: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
Reopen of PR #5442 giving Py3 compatibility. PR wouldn't update thanks to problems with multiple forks of the repo.
Fixes/Resolves/Closes (please use correct syntax):
N/A