Fixed 'pokemon_caught' event #5539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes "catch error 1" and removed redundant if/else logic
|
@Gobberwart, thanks for your PR! By analyzing the annotation information on this pull request, we identified @javajohnHub, @solderzzc and @nivong to be potential reviewers |
|
DO NOT MERGE... minor bug-fix to come. |
javajohnHub
approved these changes
Sep 19, 2016
|
pokemon_caught needs additional logic so it can be limited to only specific conditions (iv>x, cp>y etc.) as for the other ones... shrug. Someone's personal formatting preference? |
|
Should be OK to merge now |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
Fixes "catch error 2" appearing in telegram instead of correct catch message.
Fix removes a lot of redundant code. Tested with no errors.
Fixes/Resolves/Closes (please use correct syntax):