Updated Sniper docs, config.map.example and config.example files. #5554

YvesHenri · 2016-09-20T00:23:51Z

Minor Sniper fixes (including docs).

Minor Sniper fixes.

mention-bot · 2016-09-20T00:23:52Z

@YvesHenri, thanks for your PR! By analyzing the annotation information on this pull request, we identified @solderzzc, @mhdasding and @TheSavior to be potential reviewers

Gobberwart · 2016-09-20T01:15:12Z

configs/config.json.example

        "Dragonite": {},
        "Snorlax": {},
-        "// Mew evolves to Mewtwo": {},
-        "Mew": {},


Why removing these (Mew, Articuno, Zapdos, Moltres)? I know nobody's ever seen them, but what if one day... and the bot fails to snipe them :)

Those just appear in game events, which will me announced. Untill then, people are just sending fake reports to the broker, which triggers the sniper and waste a teleport.

Yeah... not sure I agree with this approach. Those are definitely VIP pokemon and if an event happens while I'm not paying attention, I'd like sniper to catch them. Also, things other than Sniper use vip pokemon list.

Agree with @Gobberwart

So, this is the only thing holding this PR up now? Bugger. I'll approve it if you change it back, otherwise... someone else will have to make the call.

Gobberwart

All good with exception of removing Articuno, Zapdos etc. from vips.

Gobberwart · 2016-09-20T05:47:54Z

good idea @cbogithub, but after the url not before it. That would let us keep semi-complicated configs in the file without having to delete them to disable.

Gobberwart · 2016-09-20T05:48:24Z

Sorry about the conflicts @YvesHenri. I fixed that vip thing which seems to have upset this.

Gobberwart · 2016-09-20T07:46:24Z

@cbogithub In the interest of letting this PR get merged without too much complication, I recommend you open a new issue as a feature request with this stuff in it.

DBa2016 · 2016-09-20T08:47:18Z

configs/config.json.map.example

 			"homing_shots": true,
 			"special_iv": 100,
-			"order": ["missing", "iv", "priority", "vip", "expiration_timestamp_ms"],
+			"order": ["missing", "vip", "priority"],
 			"sources": [
 				{
 					"url": "http://localhost:5000/raw_data",
 					"key": "pokemons",


Please add "enabled": false

I suggest disabling all sources by default, allowing user to enable exactly what he wants to

DBa2016 · 2016-09-20T08:48:20Z

configs/config.json.map.example

 						"id": { "param": "pokemon_id" },
 						"name": { "param": "pokemon_name" },
 						"latitude": { "param": "latitude" },
 						"longitude": { "param": "longitude" },
 						"expiration": { "param": "disappear_time", "format": "milliseconds" }
 					}
+				},
+				{
+					"url": "https://pokewatchers.com/grab/",


add "enabled": false, here, same reason

DBa2016 · 2016-09-20T08:48:47Z

configs/config.json.map.example

+					}
+				},
+				{
+					"url": "http://pokesnipers.com/api/v1/pokemon.json",


add "enabled": false, here, same reason

YvesHenri · 2016-09-20T10:46:55Z

At everyone requesting changes: this PR is about updating the docs/configs ONLY, since many people have been asking on slack about it. Create an issue and request features instead.

@cbogithub No. If relying solely on me, I will not do this. Like I said before, I want to keep the configs clean and simple. Setting timeout/fetch times will only trigger the possibility of more issues/nightmares. All the default times are good enough. I came to this conclusion after A LOT of tests. You are supposed to find those sources yourself and set them up, instead of relying on me. That's why this sniper has been made for.

YvesHenri · 2016-09-20T10:52:47Z

Issues are already coming up: #5560.

Fixed the bug where some pokemons were being classified as VIPs when they really werent (Gobb pushed a fix for this, but it is 'wrong' and was just a temporary one). Increased the validation timeout from 10 to 7: this IS NOT going to be customizable!!! Added the "enabled" flag for sources. Sniper's config validation wont be triggered if it is disabled. Updated the docs/configs accordingly.

YvesHenri · 2016-09-20T14:07:35Z

Couple of updates:

Fixed the potential bug with homing shots under social mode
Fixed the bug where some pokemons were being classified as VIPs when they really arent (Gobb pushed a fix for this, but it is 'wrong' and was just a temporary one)
Increased the validation timeout from 10 to 7: this IS NOT going to be customizable!!!
Added the "enabled" flag for sources
Sniper's config validation wont be triggered if it is disabled

…her the pokemon has been expired or not

YvesHenri · 2016-09-20T17:55:17Z

Conflicts resolved.

DBa2016

Okay for me now, except the change requested by @Gobberwart

kureijir · 2016-09-21T02:06:44Z

docs/configuration_files.md

@@ -735,21 +735,25 @@ This task is an upgrade version of the MoveToMapPokemon task. It will fetch poke
 ### Options
 [[back to top](#table-of-contents)]

+* `sources` - Defines whether the **WHOLE** task is enabled or not. Please bear in mind that even if the task is enabled, all or any of its sources can be disabled. (default: false)


Should this be enabled instead of sources?

Good pickup

"sources - Defines whether the WHOLE task is enabled or not. Please bear in mind that even if the task is enabled, all or any of its sources can be disabled. (default: false)" and "sources.enabled - Defines whether this source is enabled or not. This has nothing to do with the task's enabled**"**are two things completely different. Does this really sound confusing to you? Really?

It does, with line 752, not 755.

You've missed the point @YvesHenri . There is a line in configuration_files.md which reads 'sources' and it should read 'enabled'.

Finally got it. Sorry

YvesHenri · 2016-09-21T11:01:24Z

Like I said before, those legendaries will not appear in game anytime soon. They're only catchable with masterballs and those dont even exist in the game yet (acquirable). It doesnt make any sense to have them on VIP while people can fuzz any of the sniping services out there (mqtt/broker, pokesnipers, slack/discord chats etc) like I've seen many times. Encounter/catch that use this fake data can easily lead users to a ban. I dont agree that these changes should hang this PR when there is clearly a potential bug regarding this task and social mode and many other fixes/enhancements done so far. I dont agree either with the requested changes.

I will not make anymore changes, not even the ones requested by @Gobberwart. You can either accept this and make another PR customizing the config file the way you find correct (and so other people can put their thoughts exclusively on it) or you can talk to @solderzzc about handling wrong data on the mqtt/broker side (might as well talk to all the other sniping source providers).

…o dev

Added a default expiration time (5 minutes) for sniping data that does not have an expiration value. This was due I found some source that did not provide this info, although, after some testings, all of its reports were invalid data.

solderzzc · 2016-09-22T01:10:46Z

configs/config.json.example

@@ -382,16 +450,10 @@
        "Any pokemon put here directly force to use Berry & Best Ball to capture, to secure the capture rate": {},
        "any": {"catch_above_cp": 1200, "catch_above_iv": 0.9, "logic": "or" },
        "Lapras": {},
-        "Moltres": {},


It doesn't hurt anything to place these inside an example file. So we should better keep it as it.

Gobberwart · 2016-09-22T01:42:56Z

Approving/merging as-is since we can't reach agreement on vip list and that's the only thing holding this up. New PR to follow restoring vip list to how it currently is.

Updated Sniper docs, config.map.example and config.example files.

93c068d

Minor Sniper fixes.

Gobberwart reviewed Sep 20, 2016

View reviewed changes

Gobberwart suggested changes Sep 20, 2016

View reviewed changes

DBa2016 added Waiting on Changes Has conflicts labels Sep 20, 2016

DBa2016 requested changes Sep 20, 2016

View reviewed changes

YvesHenri added Second Review Required and removed Has conflicts Waiting on Changes labels Sep 20, 2016

DBa2016 added the Has conflicts label Sep 20, 2016

Fixed the parsing of the pokemon expiration info. It now detects whet…

ba4673f

…her the pokemon has been expired or not

YvesHenri added Waiting on Merge and removed Has conflicts Second Review Required labels Sep 20, 2016

DBa2016 approved these changes Sep 21, 2016

View reviewed changes

Gobberwart added the Waiting on Changes label Sep 21, 2016

kureijir reviewed Sep 21, 2016

View reviewed changes

henrimeep added 3 commits September 21, 2016 11:23

Merge branch 'dev' of https://github.com/PokemonGoF/PokemonGo-Bot int…

bc52edd

…o dev

Merge branch 'dev' of https://github.com/PokemonGoF/PokemonGo-Bot int…

7ee6213

…o dev

Fixed the docs typo (sources -> enabled).

2808ee5

Added a default expiration time (5 minutes) for sniping data that does not have an expiration value. This was due I found some source that did not provide this info, although, after some testings, all of its reports were invalid data.

solderzzc reviewed Sep 22, 2016

View reviewed changes

Gobberwart approved these changes Sep 22, 2016

View reviewed changes

Gobberwart merged commit a8d7a22 into PokemonGoF:dev Sep 22, 2016

Gobberwart mentioned this pull request Sep 22, 2016

Restore example vip list #5599

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated Sniper docs, config.map.example and config.example files. #5554

Updated Sniper docs, config.map.example and config.example files. #5554

YvesHenri commented Sep 20, 2016

mention-bot commented Sep 20, 2016

Gobberwart Sep 20, 2016 •

edited

Loading

YvesHenri Sep 20, 2016

Gobberwart Sep 20, 2016

DBa2016 Sep 21, 2016

Gobberwart Sep 22, 2016

Gobberwart left a comment

Gobberwart commented Sep 20, 2016

Gobberwart commented Sep 20, 2016

Gobberwart commented Sep 20, 2016

DBa2016 Sep 20, 2016 •

edited

Loading

YvesHenri Sep 20, 2016

DBa2016 Sep 20, 2016

DBa2016 Sep 20, 2016

YvesHenri commented Sep 20, 2016

YvesHenri commented Sep 20, 2016

YvesHenri commented Sep 20, 2016 •

edited

Loading

YvesHenri commented Sep 20, 2016

DBa2016 left a comment

kureijir Sep 21, 2016

Gobberwart Sep 21, 2016

YvesHenri Sep 21, 2016 •

edited

Loading

kureijir Sep 21, 2016

Gobberwart Sep 22, 2016

YvesHenri Sep 22, 2016

YvesHenri commented Sep 21, 2016 •

edited

Loading

solderzzc Sep 22, 2016

Gobberwart commented Sep 22, 2016

Updated Sniper docs, config.map.example and config.example files. #5554

Updated Sniper docs, config.map.example and config.example files. #5554

Conversation

YvesHenri commented Sep 20, 2016

mention-bot commented Sep 20, 2016

Gobberwart Sep 20, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Gobberwart left a comment

Choose a reason for hiding this comment

Gobberwart commented Sep 20, 2016

Gobberwart commented Sep 20, 2016

Gobberwart commented Sep 20, 2016

DBa2016 Sep 20, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YvesHenri commented Sep 20, 2016

YvesHenri commented Sep 20, 2016

YvesHenri commented Sep 20, 2016 • edited Loading

YvesHenri commented Sep 20, 2016

DBa2016 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YvesHenri Sep 21, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YvesHenri commented Sep 21, 2016 • edited Loading

Choose a reason for hiding this comment

Gobberwart commented Sep 22, 2016

Gobberwart Sep 20, 2016 •

edited

Loading

DBa2016 Sep 20, 2016 •

edited

Loading

YvesHenri commented Sep 20, 2016 •

edited

Loading

YvesHenri Sep 21, 2016 •

edited

Loading

YvesHenri commented Sep 21, 2016 •

edited

Loading