[Sniper] Extend support for different source formats #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gobberwart, thanks for your PR! By analyzing the annotation information on this pull request, we identified @YvesHenri and @GhosterBot to be potential reviewers |
Used to replace known "faulty" names with something we can recognise. Starting with "mr-mine" -> "mr. mime", but can build on this as we find more. Nidorans come to mind with unicode characters that should be "M" or "F"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
I came across a source which provides json data in a nested format, eg. instead of
{'id':1, 'name': 'pokemonname", 'lat':'blahblah' etc.}it's{'id':1 {'name': 'pokemonname", 'lat':'blahblah' etc.}}Added code to check if still a dict after getting key and looping until we get lowest nest level.
Probably not going to happen often, but we might as well support as many variations of json sources as possible.
Also adds some functionality to "fix" names that are known to cause issues, example "mr-mime" -> "mr mime". Not much there yet, but we can add to it as we find more.
Note: This does not impact existing working sources, which should be converted from dict to list by this point.
Fixes/Resolves/Closes (please use correct syntax):