Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New task: CatchLimiter #5662

Merged
merged 3 commits into from
Sep 25, 2016
Merged

New task: CatchLimiter #5662

merged 3 commits into from
Sep 25, 2016

Conversation

Gobberwart
Copy link
Contributor

@Gobberwart Gobberwart commented Sep 25, 2016

Short Description:

Adds a new task called "CatchLimiter" which enables users to automatically disable all catching tasks when balls reach a given threshold, and for a specified duration.

While each task already has a min_balls parameter (excluding Sniper), this is generally very low and often does not permit sufficient recovery time. Eg. if min_balls = 5, and you spend all 5 balls trying to catch a pokemon, you can end up stuck in an "insufficient balls" loop.

This new task basically switches off catch mode for a while so the bot can loot for a while to allow it to recover its ball collection.

I am very interested in feedback on this, and I realise it may not be useful for everyone (hence why it's disabled by default) but feedback I've had so far in slack has been positive. Users report that they often have to stop and disable catching tasks for a while when balls get low, so this should alleviate the problem.

Added new task (CatchLimiter) and required support methods/events/etc.
Green for catch_limit_off (catching resumed)
Yellow for catch_limit_on (catching paused)
@solderzzc
Copy link
Contributor

solderzzc commented Sep 25, 2016

👍 Nice to have this task.

Approved with PullApprove

@Gobberwart Gobberwart merged commit a73bddb into PokemonGoF:dev Sep 25, 2016
@crvfts
Copy link
Contributor

crvfts commented Sep 25, 2016

Working excellently! Any chance this task could also include min_interval? I found myself hunting through logger to see when bot would start catching again. Also, is there a chance this could be more effective if it took only regular Pokeballs into consideration? Personally, I'd like it to only monitor my regular Pokeballs and disable catch when only they run low so that it does not waste Great/Ultras on crap pokemon. I set my limit to 40 and it used most of my Great/Ultras. No biggie, I'll get more, but I think it would be useful if min_balls only considered regular Pokeballs only.

@Gobberwart
Copy link
Contributor Author

min_balls doesn't affect what balls are used up, just disables catching when your total balls < threshold. What you actually use to catch, or what you find from pokestops while catching is disabled is a separate issue.

Re min_interval. I might just add catch_resume_at.strftime("%H:%M:%S") wherever the bot displays a message about catching disabled, eg.

"Not catching magikarp. All catching tasks are currently disabled until 12:13:14"

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants