Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loiter new meaning #5697

Merged
merged 2 commits into from
Nov 9, 2016
Merged

Loiter new meaning #5697

merged 2 commits into from
Nov 9, 2016

Conversation

janpascal
Copy link
Contributor

Short Description:

Add a loiter option to the json path used by FollowPath. Similar to wander but it doesn't allow lower priority task to run while loitering.

Also make the progress log from FollowPAth a bit more informative by logging the location as found in the json file instead of the raw coordinates.

@janpascal
Copy link
Contributor Author

@alexyaoyang This one also OK with you?

@alexyaoyang
Copy link
Contributor

I think this is OK, but do we really need it? The exact same effect can be achieved with wander by not having any task below FollowPath, am I right?

@janpascal
Copy link
Contributor Author

Not exactly, since loiter/wander are per-point options; one might want to wander at one point of the route, and loiter at another. E.g., loiter at (one or more) known spawn points, and wander visiting a number of pokestops inbetween.

@Gobberwart
Copy link
Contributor

So... correct me if I'm wrong, but this basically means go to point, then do absolutely nothing at all for a specified number of seconds. No catching, no spinning fort, no inventory maintenance, just standing still doing nothing. Is that right? If so, what's the purpose?

@alexyaoyang
Copy link
Contributor

It could be useful to make the bot behave more human-like, most people take breaks at/near pokestops rather than randomly in the middle of a street for example. Similar to CampFort but without the need for lured forts.

@janpascal
Copy link
Contributor Author

No, during loiter the bot would still spin forts, catch pokemon etc but not any lower priority tasks like, in the default config, MoveToFort. Keep in mind that you can configure this for every point in the path, so if one of the points in the route is a spawn point you can configure to stay exactly there (loiter) for a while to catch the pokemon spawning there. Then walk to a known area with some forts: add a wander to that point in your path.json to walk to the some of the forst and spin a them. Then continue with the next point in the route.

@solderzzc
Copy link
Contributor

solderzzc commented Nov 9, 2016

👍

Approved with PullApprove

@solderzzc solderzzc merged commit a2f82b3 into PokemonGoF:dev Nov 9, 2016
solderzzc pushed a commit that referenced this pull request Nov 11, 2016
* Implement loiter option in FollowPath, loitering meaning not moving at all

* More informative progress logging for FollowPath
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants