Load CatchPokemon config in PokemonCatchWorker #5708
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
If PokemonCatchWorker is instantiated from Sniper or MoveToMapPokemon, the config passed is not the correct config for PokemonCatchWorker, which results in defaults being set instead of using the config file values.
This PR loads the CatchPokemon config into PokemonCatchWorker if no config is provided.
This solution is probably not great python, but it works. If anyone can see a better way to grab this config from the already-existing list of workers, please advise.
Fixes issues like those seen in #5696 and #5684
IMPORTANT NOTE: If the CatchPokemon task is disabled (PR #5591 which completely ignores CatchPokemon task config if the task is disabled), default values will be used instead.
Fixes/Resolves/Closes (please use correct syntax):