Do not try to transfer buddy #5752
Conversation
Was for testing only.
|
@Gobberwart, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LitRidl, @achretien and @anakin5 to be potential reviewers. |
Gobberwart
changed the title
| @@ -31,7 +32,7 @@ def work(self): | |||
|
|
|||
| if self.bot.config.release.get('all'): | |||
| group = [p for p in inventory.pokemons().all() | |||
| if p.in_fort is False and p.is_favorite is False] | |||
| if not p.in_fort and not p.is_favorite and not (p.unique_id == self.buddy['id'])] | |||
There was a problem hiding this comment.
If there is no buddy, self.buddy['id'] will give an error
There was a problem hiding this comment.
Good point. Give me a few minutes.
Was for testing only.
# Conflicts: # pokemongo_bot/cell_workers/pokemon_optimizer.py # pokemongo_bot/cell_workers/transfer_pokemon.py
|
OK that should take care of buddy not set situation. @DeXtroTip, thoughts? |
|
It could have been something like |
|
I thought about that, but figured it might still generate an error if NoneType isn't iterable. Then I thought about over-complicating that one line and just decided to palm it off to another method. |
|
If you're happy with this change @DeXtroTip could you please approve for merge? |
Short Description:
Transfer attempt of buddy pokemon currently fails and results in endless transfer loop. Added check to both TransferPokemon and PokemonOptimizer to skip trying to transfer buddy pokemon.
Fixes/Resolves/Closes (please use correct syntax):