Added dependency for urllib 1.18, telegram bot doesn't work with urll… #5895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ashleykleynhans, thanks for your PR! By analyzing the history of the files in this pull request, we identified @solderzzc, @jtdroste and @th3w4y to be potential reviewers. |
Closed
|
ping @MerlionRock looks like someone found it 😄 |
|
@davidakachaos Yup! I am trying to impanelment some basic captcha detection function to the bot, telegram will be useful to me when it encounter one. So thankful the issue is found. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
The bot installs urllib3 version 1.20 by default. This version of urllib3 doesn't work with the Telegram bot. This change sets the urllib3 dependency version to 1.18 so that the Telegram bot can function correctly.
Fixes/Resolves/Closes (please use correct syntax):
Fixes #5891