0.57.2 Gen 2 Support #5918
Merged
0.57.2 Gen 2 Support #5918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pokemons updated with Gen 2 moves. Moves and it's values updated to Gen 2. Added upgrade stone information
Api check updated to 0.57 Login logger changes with new item information
|
@MerlionRock, thanks for your PR! By analyzing the history of the files in this pull request, we identified @AdaptCharm, @pogarek and @BreezeRo to be potential reviewers. |
Contributed by @pogarek
Pokemons will have both Gen 1 & Gen 2 moves Contributed by @pogarek
Nidoran F & Nidoran M name correction
Energy can be negative, commented out test
Nidoran M & Nidoran F Correcrion again...
Change Transformed energy back to 7, change all charged move's energy back to positive values
|
I think there is an error in pokemon.json |
|
@Zyrix those are placeholders and won't affect anything. A more accurate one is almost done by @pogarek If this PR is not merged by then, I'll retrieve all the final files from him and replace them here. If it's committed, either him or myself will raise another PR. No worries. Waiting for this to be merged so that people who are waiting gen 2 support can have it, as well as the minor correction to API check. |
|
👍 |
davidakachaos
added a commit
to davidakachaos/PokemonGo-Bot
that referenced
this pull request
Feb 21, 2017
* dev: Added Gen 2 Inventory Items (PokemonGoF#5924) 0.57.2 Gen 2 Support (PokemonGoF#5918) Added Fedora > 17 support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pokemon and Pokemon Moves updated to Generation 2 support
Api check updated to 0.57
Login logger changes with new item information
EDIT: If anyone is getting these files, please also update together with the Gen 2 item support done by @atxfun