Bulktransfer improve #5995
Merged
Bulktransfer improve #5995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@walaoaaa1234, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeXtroTip, @mudmud2k and @anakin5 to be potential reviewers. |
|
Lets test |
MerlionRock
reviewed
Apr 5, 2017
| @@ -699,13 +699,15 @@ def transfer_pokemon(self, transfer): | |||
| 4: 'ERROR_POKEMON_IS_EGG', | |||
| 5: 'ERROR_POKEMON_IS_BUDDY' | |||
| } | |||
| pokemons = list(transfer) | |||
| if self.config_bulktransfer_enabled and len(pokemons) > 1: | |||
There was a problem hiding this comment.
var pokemons not found. you should change to len(transfer)
MerlionRock
reviewed
Apr 5, 2017
| @@ -699,13 +699,15 @@ def transfer_pokemon(self, transfer): | |||
| 4: 'ERROR_POKEMON_IS_EGG', | |||
| 5: 'ERROR_POKEMON_IS_BUDDY' | |||
| } | |||
| pokemons = list(transfer) | |||
| if self.config_bulktransfer_enabled and len(pokemons) > 1: | |||
| while len(pokemons) > 0: | |||
There was a problem hiding this comment.
Same problem. All pokemons should change to transfer
MerlionRock
reviewed
Apr 5, 2017
| pokemon_ids = [] | ||
| count = 0 | ||
| transfered = [] | ||
| while len(pokemons) > 0 and count < self.config_max_bulktransfer: |
There was a problem hiding this comment.
len(pokemons) -> len(transfer)
|
@walaoaaa1234 see my comments~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5992
#5987 #5988 #5994
TODO