Optimizer fix #6006
Merged
Optimizer fix #6006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidakachaos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @anakin5, @pogarek and @BriceSD to be potential reviewers. |
walaoaaa1234
approved these changes
Apr 10, 2017
This was referenced Apr 10, 2017
|
merging #6006 . Let's on dev. |
Merged
|
@davidakachaos please do new PR to dev branch . We don't do PR to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
The getting rid of Pokemons after evolving trash seems to be bugged; it transfers Pokemon who just got evolved. This moves the 2 times loop up, so the loop will re-open the iventory (with the new pokemons) and it will re-evalutate the rules with the reloaded inventory.
I hope with this fix the transfer of good Pokemon will stop
Fixes/Resolves/Closes (please use correct syntax):