Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_niantic_api logic change #6077

Merged
merged 2 commits into from
Jul 11, 2017
Merged

check_niantic_api logic change #6077

merged 2 commits into from
Jul 11, 2017

Conversation

MerlionRock
Copy link
Contributor

Now check api uses version number returned from PGoAPI rather than comparing to Bossland endpoint.

Now check api uses version number returned from PGoAPI rather than comparing to Bossland endpoint.
@MerlionRock MerlionRock mentioned this pull request Jul 11, 2017
@Jcolomar Jcolomar merged commit 61825dc into PokemonGoF:dev Jul 11, 2017
@goedzo
Copy link
Contributor

goedzo commented Jul 11, 2017

This commit does not work and causes the following error when building the container:
[2017-07-12 00:17:49] [ cli] [INFO] Most Perfect Pokemon: Traceback (most recent call last): File "pokecli.py", line 885, in <module> main() File "pokecli.py", line 195, in main bot = start_bot(bot, config) File "pokecli.py", line 147, in start_bot bot.start() File "/usr/src/app/pokemongo_bot/__init__.py", line 167, in start self._setup_api() File "/usr/src/app/pokemongo_bot/__init__.py", line 1181, in _setup_api self.login() File "/usr/src/app/pokemongo_bot/__init__.py", line 1071, in login PGoAPI_version = PGoApi.get_api_version() AttributeError: class PGoApi has no attribute 'get_api_version'

Seems that the PGoApi is not updated in Dev branch yet.

@MerlionRock
Copy link
Contributor Author

@goedzo how do you usually do update? Is it possible to rebuild the container? Just update to latest Pgoapi. Else you are running older API and risk ban.

@nimsnims
Copy link

Hi merlion. I use the command from the documeation:

docker build --build-arg BUILD_BRANCH=dev -t pokemongo-bot .

This does not update the pgoapi, so that should be fixed too. I suspect that pgoapi update is stil in Dev branch, and container just gets release branch. But tbh i dont know how to update pgoapi in a container so please let me know how i can do that.

@nimsnims
Copy link

Ps. Nimsnims & goedzo are both my github accounts.

@MerlionRock
Copy link
Contributor Author

@nimsnims let me ask around in discord

@MerlionRock
Copy link
Contributor Author

@nimsnims refer to #6075 and see last reply. See if that helps. If anymore questions, ask in that thread.

@goedzo
Copy link
Contributor

goedzo commented Jul 12, 2017

For Reference I will also post this here:

It seems that a lot of extra containers are also build in the process, so with above input I was able to find that

docker images -q

Gives all the containers. So I removed them all with the

docker rmi [image_id]

After this it seems to rebuild everything, including the pgo api.

Within the build process this seems to me the relevant line:

Collecting pgoapi from git+https://github.com/pogodevorg/pgoapi.git@develop#egg=pgoapi (from -r requirements.txt (line 4))
Cloning https://github.com/pogodevorg/pgoapi.git (to develop) to /tmp/pip-build-Rwwo7j/pgoapi

And now it seems to work correctly! So thank you for the help. I think the documentation on how to properly rebuild the container, should be added :)

This commit is actually perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants