Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.67.2 and gym support #6091

Merged
merged 26 commits into from
Jul 18, 2017
Merged

0.67.2 and gym support #6091

merged 26 commits into from
Jul 18, 2017

Conversation

goedzo
Copy link
Contributor

@goedzo goedzo commented Jul 18, 2017

Adds basic gym support. NO fighting. NO berrie feeding.

solderzzc and others added 24 commits July 12, 2017 15:53
This makes sure that we can use the GymPokemon worker to do things for us.
Update DEV: Basic gym support
Making sure my DEV is Same as Origin / Dev
@mention-bot
Copy link

@goedzo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jtdroste, @douglascamata and @MerlionRock to be potential reviewers.

Copy link
Contributor

@davidakachaos davidakachaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Just two minor references that can be removed.
Maybe (if you have time) add some documentation as well in docs?

"type": "GymPokemon",
"config": {
"enabled": false,
"feed_berries": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this anymore in the config

'healing_pokemon': 'green',
'deployed_pokemon': 'green',
'gym_error': 'red',
'fed_pokemon': 'white'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed feeding, so this can go aswel

unused config should not be in example config
Event is gone, no need to color that
@davidakachaos
Copy link
Contributor

@MerlionRock @solderzzc Things look good to me, agreed?

@MerlionRock
Copy link
Contributor

@davidakachaos @solderzzc Looks good 👍

@davidakachaos
Copy link
Contributor

davidakachaos commented Jul 18, 2017

👍

Approved with PullApprove

@MerlionRock MerlionRock merged commit 6b10582 into PokemonGoF:dev Jul 18, 2017
@Jcolomar Jcolomar mentioned this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants