-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.67.2 and gym support #6091
0.67.2 and gym support #6091
Conversation
Dev merge to master
This makes sure that we can use the GymPokemon worker to do things for us.
Update DEV: Basic gym support
Recompiled latest https://github.com/AeonLucid/POGOProtos API and added to my own maintained repository. fixes PokemonGoF#6075
Making sure my DEV is Same as Origin / Dev
Heal pokemon fix
Import Basic gym support
Import API Support for 0.67.2
@goedzo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jtdroste, @douglascamata and @MerlionRock to be potential reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Just two minor references that can be removed.
Maybe (if you have time) add some documentation as well in docs?
configs/config.json.example
Outdated
"type": "GymPokemon", | ||
"config": { | ||
"enabled": false, | ||
"feed_berries": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for this anymore in the config
'healing_pokemon': 'green', | ||
'deployed_pokemon': 'green', | ||
'gym_error': 'red', | ||
'fed_pokemon': 'white' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed feeding, so this can go aswel
unused config should not be in example config
Event is gone, no need to color that
@MerlionRock @solderzzc Things look good to me, agreed? |
@davidakachaos @solderzzc Looks good 👍 |
Adds basic gym support. NO fighting. NO berrie feeding.