Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart pinap function #6133

Merged
merged 5 commits into from
Jul 25, 2017
Merged

Smart pinap function #6133

merged 5 commits into from
Jul 25, 2017

Conversation

ChiefM3
Copy link
Contributor

@ChiefM3 ChiefM3 commented Jul 25, 2017

Short Description:

  • Added a new "smart pinap" function. Throws a pinap berry according to the catch rate which does not interfere with the existing razz berry logic.
  • ex: If smart_pinap_enabled=true && smart_pinap_threshold = 0.85 && berry_threshold = 0.4, pokemon with catch rate 0-0.4 will be razzed, 0.85-1 will be pinapped.
  • descriptions added to configuration_files.md

Fixes/Resolves/Closes (please use correct syntax):

@ChiefM3
Copy link
Contributor Author

ChiefM3 commented Jul 25, 2017

Thank you @nbq for walking me through my first PR!

@nbq
Copy link
Collaborator

nbq commented Jul 25, 2017

@ChiefM3 you are very welcome!

@MerlionRock
Copy link
Contributor

MerlionRock commented Jul 25, 2017 •
edited by douglascamata
Loading

👍

Approved with PullApprove

@MerlionRock MerlionRock merged commit 61572dc into PokemonGoF:dev Jul 25, 2017
@MerlionRock
Copy link
Contributor

Congrats on your 1st PR

@ChiefM3 ChiefM3 deleted the fix_pinap branch July 25, 2017 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChiefM3 @nbq @MerlionRock