Fixes stationary walks in SpiralNavigation #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
July 25, 2016 09:05
(distances lower than speed should be walked directly)
ghost
mentioned this pull request
| @@ -44,7 +44,8 @@ def step(self): | |||
| # print 'distance' | |||
| # print dist | |||
|
|
|||
| if (self.dLat == 0 and self.dLng == 0) or dist < 15: | |||
| if (self.dLat == 0 and self.dLng == 0) or dist < self.speed: | |||
There was a problem hiding this comment.
@tstumm I think dist < self.speeed isn't going to work correctly. Since random_lat_long_delta() returns something between -9.1 and 9.1, we really need something like self.speed < dist + 9.1 Otherwise we could walk past and go on for ever.
MFizz
pushed a commit
to MFizz/PokemonGo-Bot
that referenced
this pull request
Jul 29, 2016
* Fixed sleep to use floats again * Fixed sleep to use floats again PokemonGoF#2 * Refactored jitter to have its own function to be used elsewhere * Fixes SpiralNavigation skipping waypoints * Fixing stationary movements * Improved StepWalker (distances lower than speed should be walked directly)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
Fixes stationary walks by reworking StepWalker
Fixes: