Proper logging & minor refactoring #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 21, 2016 22:10
|
basically all print are now removed. If we want to change the logging prefix to something fancy, we can do so at one central point (like there was on some print statements |
|
on it |
|
hm, rebasing looks like redoing it, since you also split files. I ll wait until you merge, and go on from there. |
|
closing this one in favor of #91 |
Closed
jpfroud
added a commit
to jpfroud/PokemonGo-Bot
that referenced
this pull request
Aug 20, 2016
[ERROR] Unexpected moveset [Lick, Aqua Tail] for PokemonGoF#86 Seel, please update info in pokemon.json and create issue/PR
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started cleaning up a bit.
If you like this, I can continue. I will try to simplify the code and make it more readable.