Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

US election banner #2143

Merged
merged 13 commits into from
Oct 30, 2024
Merged

US election banner #2143

merged 13 commits into from
Oct 30, 2024

Conversation

anth-volk
Copy link
Collaborator

@anth-volk anth-volk commented Oct 28, 2024 •
edited
Loading

Description

Fixes #2142.

Changes

Creates new US election banner for the US site.

Screenshots

AwesomeScreenshot-10_28_2024.3_51_34PM.mp4

Tests

N/A

@anth-volk anth-volk marked this pull request as draft October 28, 2024 14:55
@anth-volk
Copy link
Collaborator Author

Would love particular review of the following:

  • Is the article button text satisfactory? Each has a long and short form, I tried to show both in the recording
  • Do we want the buttons colored differently?
  • Does the hero image work?

@anth-volk
Copy link
Collaborator Author

Here's the component as of now

AwesomeScreenshot-10_28_2024.7_14_41PM.mp4

@anth-volk
Copy link
Collaborator Author

And here's a better demonstration of its responsivity

AwesomeScreenshot-10_28_2024.7_18_20PM.mp4

@anth-volk
Copy link
Collaborator Author

Looks like it didn't load, trying again
AwesomeScreenshot-10_28_2024,7_18_20PM.webm

@anth-volk anth-volk force-pushed the feat/us-election-banner branch 2 times, most recently from 52c766b to 2e8c2fe Compare October 29, 2024 20:09
@MaxGhenis
Copy link
Contributor

Looks great - can we merge without the remaining two articles for now?

@anth-volk
Copy link
Collaborator Author

The two buttons would remain links to nowhere. If that's alright, sure; alternatively, I could remove the two buttons for the missing articles early tomorrow, then take the remaining three primary articles and extend their size to fill the void.

@anth-volk
Copy link
Collaborator Author

anth-volk commented Oct 30, 2024 •
edited
Loading

Removed unfinished articles and redistributed columns. Here's what it looks like now:
AwesomeScreenshot-10_30_2024,4_51_59PM.webm

I'd advocate for merging, then adding the remaining articles and adjusting grid as necessary in separate PRs.

@anth-volk anth-volk marked this pull request as ready for review October 30, 2024 15:54
@MaxGhenis
Copy link
Contributor

I meant to remove the buttons

@anth-volk
Copy link
Collaborator Author

The two have been removed

@MaxGhenis MaxGhenis merged commit 515ef5f into PolicyEngine:master Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGhenis MaxGhenis MaxGhenis approved these changes

@nikhilwoodruff nikhilwoodruff Awaiting requested review from nikhilwoodruff

Assignees
No one assigned
Labels
None yet
Projects
policyengine-app
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

US election banner
2 participants
@anth-volk @MaxGhenis