Repair wrappedJsonStringify, modify reformDefinitionCode #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikhilwoodruff This is one of the two other issues I mentioned in the standup |
nikhilwoodruff
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2106.
Changes
Previously, we improperly handled advanced features of
JSON.stringify()withinwrappedJsonStringify, causing the Reproduce in Python page to treatInfinityasnull. Further, we had no means of importingnumpyin the Reproduce in Python output. This PR changeswrappedJsonStringifyto properly handle more than two arguments toJSON.stringify()and modifiesreformDefinitionCodeto check if any baseline or reform values are infinite, at which point it adds a line to import numpy.Screenshots
AwesomeScreenshot-10_31_2024.9_15_43PM.webm
Tests
The code output was tested within a local run of
-usand appears to work correctly.