Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Federal to Tax revenues when budgetary impacts are split out #672

Closed
wants to merge 2 commits into from

Conversation

QianruZhang78
Copy link
Collaborator

@QianruZhang78 QianruZhang78 commented Aug 9, 2023

Fixes #667

πŸ€– Generated by Copilot at 9e280ca

Summary

βœ¨πŸ›πŸŽ¨

This pull request introduces a new function formatPercentageChange to standardize the formatting of percentage changes in various charts and components. It also updates the InequalityImpact, PovertyImpact, and BudgetaryImpact components to use the new function and fix some layout and logical errors.

Sing, O Muse, of the skillful coder who devised
A cunning function formatPercentageChange to adorn
The charts and texts with signs and digits well arranged
And make the app more pleasing to the eye and mind.

Walkthrough

  • Add a new function formatPercentageChange to standardize the formatting of percentage changes across the app (link)
  • Fix a logical error in the BudgetaryImpact component to match the region with the correct tax revenue labels (link)
  • Use the new function formatPercentageChange to format the percentage changes in the InequalityImpact and PovertyImpact components (link, link, link, link, link)
  • Change the uniformtext mode to show in the InequalityImpact component to improve the readability of the text annotations in the chart (link)

@QianruZhang78 QianruZhang78 changed the title Fix #623: Add Federal to Tax revenues when budgetary impact split in Fix #623: Add Federal to Tax revenues when budgetary impacts are split out Aug 9, 2023
@QianruZhang78 QianruZhang78 marked this pull request as ready for review August 9, 2023 04:23
@QianruZhang78
Copy link
Collaborator Author

QianruZhang78 commented Aug 9, 2023

Now it is "Federal tax revenues" in state reforms and "Tax revenues" when region is "us", the issue was caused by a condition that was meant to be flipped.
Screen Shot 2023-08-09 at 12 18 48 AM
Screen Shot 2023-08-09 at 12 20 56 AM

@MaxGhenis MaxGhenis changed the title Fix #623: Add Federal to Tax revenues when budgetary impacts are split out Add Federal to Tax revenues when budgetary impacts are split out Aug 9, 2023
@MaxGhenis
Copy link
Contributor

Thanks, and does this still only say tax revenues (no state/federal) outside the US?

@QianruZhang78 QianruZhang78 linked an issue Aug 9, 2023 that may be closed by this pull request
@QianruZhang78
Copy link
Collaborator Author

Thanks, and does this still only say tax revenues (no state/federal) outside the US?

Nope, now all tax revenues are specified as either state or federal outside the US. But allow me to recreate a pull request as now it is linked to a wrong source branch, sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Federal to Tax revenues when budgetary impacts are split out
2 participants