Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update US Default object for the calculate route request #703

Closed
wants to merge 1 commit into from

Conversation

samau3
Copy link
Collaborator

@samau3 samau3 commented Aug 20, 2023

Fixes #702

The status information for the calculate endpoints is determined by making a request to the endpoints with basic household data as an object with key value pairs. So if the endpoints have changed in regards to what keys and/or values it can accept, then this status page may incorrectly show an Error for the endpoint route. Therefore, the DEFAULT_US_HOUSEHOLD object needed to be updated to better match the expected data structure for the API.

🤖 Generated by Copilot at dece71d

Summary

Walkthrough

@MaxGhenis
Copy link
Contributor

Will we need to update this each time we add/remove a variable from policyengine-us?

@anth-volk
Copy link
Collaborator

This is now engineered more flexibly so that the default household on the front end starts as an empty object, then variables are added with their default values to prevent breaking when variables are renamed in the country packages. Closing.

@anth-volk anth-volk closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Issue with PolicyEngine status page for US Calculate
3 participants