-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Used np.divide with out and where parameters #5501
Used np.divide with out and where parameters #5501
Conversation
Thanks @SonaliBedge! Could you please:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5501 +/- ##
==========================================
- Coverage 99.12% 99.04% -0.08%
==========================================
Files 2592 2678 +86
Lines 37707 38807 +1100
Branches 162 168 +6
==========================================
+ Hits 37378 38438 +1060
- Misses 297 335 +38
- Partials 32 34 +2 ☔ View full report in Codecov by Sentry. |
Thank you, Max, for your comments. I will make all the above changes. This is my first Policy Engine PR, and I wasn’t fully familiar with the process, which is why I didn’t remove the commented code. |
Populate changelog_entry.yaml not changelog.yaml |
Fixes issue #4888 (Used np.divide NumPy function with out and where parameters to solve invalid value encountered when dividing employment_income by total_earnings in marginal tax rate calculation.)