Fixes Issue 56 #58
Merged
Fixes Issue 56 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobtastic/task.py:152:1: W293 blank line contains whitespace jobtastic/tests/test_broker_fallbacks.py:118:66: E231 missing whitespace after ':' jobtastic/tests/test_broker_fallbacks.py:124:66: E231 missing whitespace after ':' jobtastic/tests/test_broker_fallbacks.py:129:67: E231 missing whitespace after ':' jobtastic/tests/test_broker_fallbacks.py:135:67: E231 missing whitespace after ':' jobtastic/tests/test_broker_fallbacks.py:200:66: E231 missing whitespace after ':' jobtastic/tests/test_broker_fallbacks.py:209:67: E231 missing whitespace after ':'
| @@ -349,6 +349,16 @@ all of your arguments must be keyword arguments. | |||
| Note: This is a limitation of the current `significant_kwargs` implementation, | |||
| and totally fixable if someone wants to submit a pull request. | |||
|
|
|||
| ### async_or_eager | |||
There was a problem hiding this comment.
👍
Could we list these two below the delay_or versions? My impression is that most folks will continue to use the simpler signature of delay_or.
There was a problem hiding this comment.
I think listing the two async_ versions after the delay_ versions still makes sense.
winhamwr
suggested changes
Sep 23, 2016
|
Fixed. I thought I had already addressed your comments but we were waiting on me =P |
|
Do you think it's worth adding a test on |
|
Looking through the documentation of result, I don't see anything that would change as a result of something we passed in to |
winhamwr
approved these changes
Sep 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue 56
#56