Peripheral mode — basic setup, few methods implemented #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cierpliwy
reviewed
Oct 27, 2017
| willRestoreStateSubject.onNext(dict) | ||
| } | ||
|
|
||
| func peripheralManagerDidStartAdvertising(_: CBPeripheralManager, error: Error?) { |
There was a problem hiding this comment.
Missing logs for all other callbacks.
Source/CentralManager.swift
Outdated
| @@ -170,36 +168,31 @@ public class BluetoothManager { | |||
| return operation | |||
| }() | |||
| // Allow scanning as long as bluetooth is powered on | |||
| return strongSelf.ensure(.poweredOn, observable: observable) | |||
| return strongSelf.ensure(state: .poweredOn, observable: observable) | |||
There was a problem hiding this comment.
if we are changing signature here we could rename second to for
Source/PeripheralManager.swift
Outdated
| /// - parameter peripheralManager: CBPeripheralManager instance used to perform peripheral mode operations | ||
| /// - parameter queueScheduler: Scheduler on which all serialised operations are executed (such as scans). By default main thread is used. | ||
| init(peripheralManager: CBPeripheralManager, | ||
| queueScheduler: SchedulerType = ConcurrentMainScheduler.instance) { |
There was a problem hiding this comment.
queueScheduler is not needed.
Source/PeripheralManager.swift
Outdated
|
|
||
| /// Creates new `PeripheralManager` | ||
| /// - parameter peripheralManager: CBPeripheralManager instance used to perform peripheral mode operations | ||
| /// - parameter queueScheduler: Scheduler on which all serialised operations are executed (such as scans). By default main thread is used. |
There was a problem hiding this comment.
Remove line from comment as well
Source/PeripheralManager.swift
Outdated
| } | ||
|
|
||
| public typealias AdvertisingStarted = Void | ||
| //TODO: Docs |
Source/PeripheralManager.swift
Outdated
| .subscribe(onNext: { [weak self] advertisement in | ||
| self?.peripheralManager.startAdvertising(advertisement) | ||
| }) | ||
| strongSelf.peripheralManager.startAdvertising(advertisementData.value) |
There was a problem hiding this comment.
Remove this line and skip(1) from above?
There was a problem hiding this comment.
Good catch! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
I've setup a new class for
CBPeripheralManagerreactive wrapper. I've renamed the currentBluetoothManagerintoCentralManagerwhich probably makes more sense.Implemented sharing of basic things like state management and helper function between two managers.
For
PeripheralManagerfull wrappers around the delegates are written.Also implemented initialisers, basic properties and
startAdvertisingmethod. It still needs some polishing like documentation. I will add this later today.Partially addresses #166
More of the interface for
PeripheralManagerwill be added in subsequent PRs — it's done this way to break it down into smaller pieces, more manageable to review them.Please let me know what you think!