Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🙅🏻‍♂️ Hide instantiator behind feature flag #389

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Sep 3, 2024

What?

When on-chain-release-build feature is used, don't compile the instantiator

Why?

Makes the runtime smaller

Testing

  • Successfully ran pallet tests, integration tests, benchmark tests, dry-run-benches, and srtool wasm

Copy link
Contributor Author

JuaniRios commented Sep 3, 2024

@JuaniRios JuaniRios mentioned this pull request Sep 3, 2024
@JuaniRios JuaniRios changed the title hide instantiator behind feature flag 🙅🏻‍♂️ Hide instantiator behind feature flag Sep 3, 2024
@JuaniRios JuaniRios marked this pull request as ready for review September 3, 2024 07:11
Copy link

graphite-app bot commented Sep 3, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (09/03/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios force-pushed the 09-03-hide_instantiator_behind_feature_flag branch from f85e6af to 42c5253 Compare September 3, 2024 13:20
@JuaniRios JuaniRios force-pushed the 09-03-hide_instantiator_behind_feature_flag branch from 42c5253 to 0ab3ae3 Compare September 3, 2024 14:06
@JuaniRios JuaniRios force-pushed the 09-03-hide_instantiator_behind_feature_flag branch from 0ab3ae3 to 20873b6 Compare September 3, 2024 14:18
@JuaniRios JuaniRios force-pushed the 09-03-hide_instantiator_behind_feature_flag branch from 20873b6 to c6c8084 Compare September 3, 2024 14:27
@JuaniRios JuaniRios force-pushed the 09-03-hide_instantiator_behind_feature_flag branch from c6c8084 to 9caa1ec Compare September 3, 2024 14:35
@JuaniRios JuaniRios force-pushed the 09-03-hide_instantiator_behind_feature_flag branch from 9caa1ec to c7db686 Compare September 4, 2024 13:07
Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, it makes sense to exclude the instantiator from the production build, but this actually increases the runtime size, potentially defeating the purpose of the PR. (You can check in the screenshot the difference in size between this PR, and the previous one in the stack)

image.png

While running a few tests with cargo tree, I also noticed that the polimec-common-test-utils crate is also being included in the runtime, which it shouldn't be. We likely need to find a way to exclude that crate from the runtime as well.

Copy link
Contributor Author

JuaniRios commented Sep 10, 2024

Merge activity

  • Sep 10, 4:36 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Sep 10, 4:39 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 10, 4:40 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 08-30-fix_docs to graphite-base/389 September 10, 2024 08:36
@JuaniRios JuaniRios changed the base branch from graphite-base/389 to main September 10, 2024 08:37
@JuaniRios JuaniRios force-pushed the 09-03-hide_instantiator_behind_feature_flag branch from 8774793 to c0be409 Compare September 10, 2024 08:38
@JuaniRios JuaniRios merged commit 182b4f4 into main Sep 10, 2024
1 check passed
@JuaniRios JuaniRios deleted the 09-03-hide_instantiator_behind_feature_flag branch September 10, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants