-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🙅🏻♂️ Hide instantiator behind feature flag #389
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @JuaniRios and the rest of your teammates on Graphite |
Graphite Automations"Auto-assign PRs to author" took an action on this PR • (09/03/24)1 assignee was added to this PR based on Juan Ignacio Rios's automation. |
d09be97
to
6bbf6ae
Compare
f85e6af
to
42c5253
Compare
6bbf6ae
to
c8178e0
Compare
42c5253
to
0ab3ae3
Compare
c8178e0
to
80bb6c4
Compare
0ab3ae3
to
20873b6
Compare
80bb6c4
to
490f67d
Compare
20873b6
to
c6c8084
Compare
490f67d
to
a5c57f2
Compare
c6c8084
to
9caa1ec
Compare
a5c57f2
to
318a5ce
Compare
9caa1ec
to
c7db686
Compare
318a5ce
to
b2bec75
Compare
c7db686
to
6a5970b
Compare
b2bec75
to
6029bf2
Compare
6a5970b
to
8774793
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, it makes sense to exclude the instantiator from the production build, but this actually increases the runtime size, potentially defeating the purpose of the PR. (You can check in the screenshot the difference in size between this PR, and the previous one in the stack)
While running a few tests with cargo tree
, I also noticed that the polimec-common-test-utils
crate is also being included in the runtime, which it shouldn't be. We likely need to find a way to exclude that crate from the runtime as well.
Merge activity
|
8774793
to
c0be409
Compare
What?
When on-chain-release-build feature is used, don't compile the instantiator
Why?
Makes the runtime smaller
Testing