Add ARCropolis Compatability #36
Conversation
|
Thanks for your pr ! I'll review and test it in few days :) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
source/extract.cpp
Outdated
| std::string nameWithoutExtension = ""; | ||
| size_t extensionPos = archiveFile.find_last_of("."); // Find last dot position | ||
| if (extensionPos != std::string::npos && archiveFile.substr(extensionPos) == ".zip") { | ||
| nameWithoutExtension = archiveFile.substr(0, extensionPos); // Extract substring |
| if (archive_entry_filetype(entry) == AE_IFDIR) { | ||
| // Create the directory | ||
| if (!std::filesystem::create_directory(outputPath)) { |
There was a problem hiding this comment.
Good idea, maybe it would be interesting to do it even if ARCropolis is not used.
|
I don't have smash bros ultimate so I can't test. Can you confirm me that it's working |
|
I have another idea. Like SimpleModManager can be launcher/downloader from The app maybe you can do the same for ARCropolis ? |
|
I have made the appropriate changes and retested, everything works as intended. Mods for ARCropolis and the standard game mods install fine. I also removed some unused code. As for installing ARCropolis from the HBAppStore, I'm not sure why it isn't provided as a package. |
|
Nice to see. The first commit has one mistake there is two time te condition with .zip. But you corrected it. I'll merge this very good pr |
This adds support for ARCropolis - a modding framework for Super Smash Bros. Ultimate. The majority of mods for Smash Ultimate on Gamebanana require ARCropolis and shouldn't be placed in
/modsor/Atmposphere/contents. ARCropolis mods also don't follow theromfsandexefsstructure. This pull request adds a setting option to install complete Smash mods to the ARCropolis mod location (/ultimate/mods). The setting will also be added to thesettings.jsonfile if it is not present so the config file doesn't have to be redistributed. And it defaults to off.