Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FileDialog.starting_directory for xdg desktop portal backend #179

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Implement FileDialog.starting_directory for xdg desktop portal backend #179

merged 2 commits into from
Feb 21, 2024

Conversation

theRookieCoder
Copy link
Contributor

@theRookieCoder theRookieCoder commented Feb 21, 2024 •
edited
Loading

Implements FileDialog.starting_directory for the xdg desktop portal backend using ashpd::OpenFileRequest::current_folder

Fixes #42

@theRookieCoder
Copy link
Contributor Author

theRookieCoder commented Feb 21, 2024 •
edited
Loading

Unfortunately a bug (which I can't quite track down on KDE's implementation of portal) causes this functionality to not work on KDE, but it does work on GNOME. I haven't tested it on any other desktop environments yet.

@theRookieCoder
Copy link
Contributor Author

theRookieCoder commented Feb 21, 2024 •
edited
Loading

The current_folder option is implemented (https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/blob/master/src/filechooser.cpp#L371-373 and https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/blob/master/src/kirigami-filepicker/api/mobilefiledialog.cpp#L137-140), it's just the file manager I'm using (Dolphin) that doesn't implement it probably.

@PolyMeilex PolyMeilex merged commit 4271d21 into PolyMeilex:master Feb 21, 2024
11 of 13 checks passed
@PolyMeilex
Copy link
Owner

Thanks!

@Be-ing
Copy link
Contributor

Be-ing commented Feb 21, 2024

Thanks for following up on my old TODO!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

starting directory support with XDG Desktop Portal backend
3 participants
@theRookieCoder @PolyMeilex @Be-ing