Fixed Notebook Tests #52
Conversation
There was a problem hiding this comment.
@pjflux2001 thank you for getting this working. Looks good but I just put up a few concerns. Do we need the production folder? PolyPhy/experiments/jupyter /production/ The path looks very long. Could you also squash your commits to one issue. The conventional way should be one commit per issue fixed, this avoids us getting passed the 2GB that git provides.
| @@ -30,6 +30,9 @@ jobs: | |||
| python -m pip install flake8 pytest | |||
| if [ -f requirements.txt ]; then pip install -r requirements.txt; fi | |||
| pip install . -U | |||
| - name: Create Flag File | |||
| run: | | |||
| touch /tmp/flag | |||
There was a problem hiding this comment.
I have not used this but do we really need it?
There was a problem hiding this comment.
Yes, this is needed. Might not be most efficient way to do it - but I couldn't think of a better approach yet
Since the 3D mask jupyter notebook isn't yet working / incomplete, I checked with @OskarElek and he suggested segregating it from the other notebooks. Hence, this change in path. @OskarElek could you please turn on squashing : https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests |
Closes #41