fix sumo #10
Merged
fix sumo #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
going to merge, it worked fine in testing and it can be altered later, especially after testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is probably extremely inefficient but it was the only way I was able to get it to work. RenderWorldLastEvent fires every tick or something, which was what was screwing me over in the beginning as I didn't know it did that. I added a check to only do stuff on the first fire. The old implementation also meant that it was impossible to change render distance at all. This has been fixed so that resetting render distance only happens if you have just come out of sumo. I also tested directly queueing another sumo after the first one ends and saw no problems there, so this shouldn't cause any issues.
The only possible issues I can think of are Alt-F4'ing the game while in a sumo match or getting the bug where Minecraft sometimes doesn't save changes if you leave the game quickly afterward.
Also, I added some more stuff to Game Tips Hider.