Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable LWJGL manager when using Pojav #271

Merged
merged 2 commits into from
Jul 1, 2023
Merged

disable LWJGL manager when using Pojav #271

merged 2 commits into from
Jul 1, 2023

Conversation

Wyvest
Copy link
Member

@Wyvest Wyvest commented Jul 1, 2023

Description

Pojav already uses LWJGL 3 internally (including NanoVG) so loading our own just causes a host of issues.

Related Issue(s)

Checklist

  • I made a clear description of what was changed
  • I stated why these changes were necessary
  • I updated documentation or said what needs to be updated
  • I made sure these changes are backwards compatible
  • This pull request is for one feature/bug fix

@Wyvest Wyvest mentioned this pull request Jul 1, 2023
Closed
@Wyvest Wyvest linked an issue Jul 1, 2023 that may be closed by this pull request
Pojav does not work with OneConfig NanoVG #269
Closed
@Wyvest Wyvest requested review from nextdayy and xtrm-en July 1, 2023 12:30
nextdayy
nextdayy approved these changes Jul 1, 2023
View reviewed changes
Copy link
Member

@nextdayy nextdayy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (idk if it works with pojav)

@Wyvest Wyvest added this pull request to the merge queue Jul 1, 2023
Merged via the queue into develop with commit d2d1dd7 Jul 1, 2023
@Wyvest Wyvest deleted the pojav branch July 1, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nextdayy nextdayy nextdayy approved these changes

@xtrm-en xtrm-en Awaiting requested review from xtrm-en

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pojav does not work with OneConfig NanoVG
2 participants
@Wyvest @nextdayy