This repository has been archived by the owner on Oct 24, 2021. It is now read-only.
Support object index signatures. #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aomarks
force-pushed
the
object
branch
3 times, most recently
from
e2c22f3
to
00b46e5
Compare
justinfagnani
approved these changes
Dec 18, 2017
src/closure-types.ts
Outdated
| @@ -264,6 +276,13 @@ function isBareArray(node: doctrine.Type): | |||
| return node.type === 'NameExpression' && node.name === 'Array'; | |||
| } | |||
|
|
|||
| function isParameterizedObject(node: doctrine.Type): | |||
| node: doctrine.type.TypeApplication, | ||
| templateTypes: string[]): ts.IndexableObjectType|ts.NameType { | ||
| if (node.applications.length !== 2) { | ||
| console.error('Parameterized Object must have two parameters.'); |
There was a problem hiding this comment.
maybe assert and/or throw since this should be an internal error?
There was a problem hiding this comment.
It's not an internal error, actually there is a case in Polymer where a function was annotated with Object<Node> which isn't valid AFAIK (we are changing it).
Closure `Object<foo, bar>` maps to TypeScript `{[key: foo]: bar}`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closure
Object<foo, bar>maps to TypeScript{[key: foo]: bar}.