This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Cache the polyfills in runtimeCaching #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdonrd
force-pushed
the
abdonrd-patch-1
branch
from
6731b6b
to
b820a41
Compare
|
About the
|
keanulee
reviewed
Sep 29, 2017
sw-precache-config.js
Outdated
| navigateFallback: 'index.html', | ||
| runtimeCaching: [ | ||
| { | ||
| urlPattern: /bower_components\/webcomponentsjs\/.*.js/, |
There was a problem hiding this comment.
Let's keep the leading slash, so it doesn't match foobower_components/.
urlPattern: /\/bower_components\/webcomponentsjs\/.*.js/,There was a problem hiding this comment.
Maybe ^ would be better? (I'm not 100% sure it will work)
urlPattern: /^bower_components\/webcomponentsjs\/.*.js/,To maintain consistency, since the entire project has relative paths.
There was a problem hiding this comment.
@abdonrd Wouldn't that break relative paths though since it would match /bower_components/ but not /subdirectory/bower_components/?
Edit: Now that I think about it, if it's a path, wouldn't that example break everywhere since it should contain a / at the beginning?
(Not exactly sure what this is being matched against)
keanulee
approved these changes
Oct 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @frankiefu recommended here: Polymer/news#141 (comment)
Also, add images to
staticFileGlobs.