This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Update manifest.json #1067
Merged
Update manifest.json #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdonrd
suggested changes
Oct 2, 2017
manifest.json
Outdated
| "start_url": "/", | ||
| "display": "standalone", | ||
| "theme_color": "#3f51b5", | ||
| "background_color": "#3f51b5", |
There was a problem hiding this comment.
Please, remove the trailing comma.
abdonrd
approved these changes
Oct 2, 2017
frankiefu
approved these changes
Oct 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of the changes in #1049 and discussions linked to from that PR, we're updating the web manifest to be consistent with Shop and News.
start_urlis set to absolute/. This is because with prpl-server, manifest.json is served from the build-specific directory (e.g. /es6-bundled/manifest.json), and the manifest needs to cover URLs outside of that directory (e.g. "/", or "/list/1")utm_*) will be excluded and left to user's choicescopewill be left undefined. It is assumed that everything on the same origin is in scope.srcs are always relative to manifest.json, (even with prpl-server when they would be served from /es6-bundled/images/manifest/...png)As a result of these changes, serving the app out of a non-root URL (e.g. example.com/my-app/) will require changes to the manifest. Changes are already required in other parts of the app (e.g. the
<base>tag in index.html), so this wouldn't be a new issue.