Updates for Polymer 3 #1096

bicknellr · 2018-04-18T01:12:45Z

Paths are now name specifiers.
Removes bower.json.
License updates which need to be confirmed.
- I pulled LICENSE from one of the tools repos because this removes bower.json, which previously linked to the license text.
- Confirm license text.
Fix polymer test; possibly related to polymer serve starting in 'component' mode?
Confirm URL format for script tags in HTML. (./node_modules/dep vs ../dep)

bicknellr · 2018-04-18T01:20:26Z

polymer test doesn't seem to work. Also, there are a couple of extra specifiers I forgot.

remove eslint

license

xxx xxxx

abdonrd

I just added changes at #1097.

Polymer 3 project update

googlebot · 2018-04-18T19:09:08Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot · 2018-04-18T19:17:17Z

☹️ Sorry, but only Googlers may change the label cla: yes.

googlebot · 2018-04-18T19:26:26Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

keanulee · 2018-04-18T22:08:29Z

LICENSE

+SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.


Remove this file - canonical license file is already referenced at the top of source files.

This files allow us to have the GitHub license preview:

Reference: GitHub Help: Adding a license to a repository

Ack on the GitHub license preview, but this is not something we're broadly adopting across our repos at this time.

Are we leaving the license field in package.json?

Yes, that's fine (needed to suppress npm warning).

keanulee · 2018-04-18T22:10:10Z

polymer.json

@@ -2,7 +2,8 @@
  "entrypoint": "index.html",
  "shell": "src/my-app.js",
  "sources": [
-    "images/**/*"
+    "images/**/*",
+    "src/**/*"


Is this necessary? I've been removing them in other 3.0 projects since it didn't seem to do anything (build discovers the tree through import statements).

The truth is that I'm not sure.

Ping to @aomarks @justinfagnani @FredKSchott ?

@usergenic might also know.

If the source file is imported somewhere with a string literal identifier (i.e. not by concatenation or variable reference) then you shouldn't need them here. However this is good if your source filenames can not be statically resolved by build.

I'm going to revert this then - it doesn't seem to be affecting anything yet. Also, I talked w/ @usergenic off of GitHub and he said that shell is one of the roots of this graph and dynamic imports are considered when finding other sources. Given that src/my-app.js eventually gets to all of the files in src through both regular and dynamic imports, it should be sufficient to get the whole graph. This should be easy to add back later if we find it's better.

… the top of files.

googlebot · 2018-04-18T22:40:33Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

notwaldorf · 2018-04-19T12:04:42Z

README.md

@@ -79,14 +79,14 @@ Run `polymer help build` for the full list of available options and optimization

 This command serves your app. Replace `build-folder-name` with the folder name of the build you want to serve.

-    polymer serve build/build-folder-name/
+    npm start build/build-folder-name/


is this true? i.e. have you tested this

@abdonrd added these as npm scripts in package.json, they use the cli there, and I think this means that you don't have to install the cli globally to run through these instructions anymore.

@bicknellr exactly! Use the Polymer CLI installed in the project.
It helps to avoid install the Polymer CLI globally. And more now that it is in alpha.

Also the users can use the common npm start, npm test, etc scripts.

notwaldorf · 2018-04-19T12:05:09Z

index.html


    <!-- Load your application shell -->
-    <script type="module" src="./src/my-app.js"></script>
+    <script type="module" src="src/my-app.js"></script>


why are the relative paths wrong?

Should we set it like this and use the base tag to support the PRPL Server?

Don't think this change makes a difference since it's still a relative URL that uses the base tag. No action needed.

notwaldorf · 2018-04-19T12:07:30Z

src/my-app.js

-subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
-*/
+ * @license
+ * Copyright (c) 2018 The Polymer Project Authors. All rights reserved.


blehhhh pinging @azakus to double check we should be bumping this year (i guess it's technically a new file?)

Substantial edits have been made, so updating is fine.

Only new new files need a new date AFAIK

I've changed the dates back.

bicknellr · 2018-04-19T19:09:25Z

src/my-app.js

 setPassiveTouchGestures(true);
+
 setRootPath(Polymer.rootPath);


Polymer doesn't seem to be getting imported from anywhere.

It's set as a global in index.html. I'm going to skip doing anything about that in this PR but I think these might make sense to move out to index.html too? I've opened a branch (global-settings) to look at this.

bicknellr · 2018-04-19T19:10:11Z

README.md


 ### Build

-The `polymer build` command builds your Polymer application for production, using build configuration options provided by the command line or in your project's `polymer.json` file.
+The `npm run build` command builds your Polymer application for production, using build configuration options provided by the command line or in your project's `polymer.json` file.

 You can configure your `polymer.json` file to create multiple builds. This is necessary if you will be serving different builds optimized for different browsers. You can define your own named builds, or use presets. See the documentation on [building your project for production](https://www.polymer-project.org/2.0/toolbox/build-for-production) for more information.


I should find the new link for https://www.polymer-project.org/2.0/toolbox/build-for-production.

bicknellr · 2018-04-19T19:12:33Z

src/my-app.js

+          </iron-pages>
+        </app-header-layout>
+      </app-drawer-layout>
+    `;
  }

  static get is() { return 'my-app'; }


I don't think the is getter is necessary anymore.

googlebot · 2018-04-20T17:27:33Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

bicknellr · 2018-04-20T23:06:00Z

FWIW, I think googlebot was worried that my merge commit which has my personal email attached to it (thanks to GitHub not letting me choose which to use on which repos) is somebody new.

googlebot · 2018-04-21T00:24:31Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

bicknellr · 2018-04-21T01:00:27Z

Chill out googlebot, it's still just me.

googlebot · 2018-04-21T01:00:42Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

bicknellr added 2 commits April 17, 2018 17:58

Remove bower.json; update package.json; use name specifiers.

5231e09

Add LICENSE.

de5a683

bicknellr requested review from abdonrd, keanulee and notwaldorf April 18, 2018 01:12

googlebot added the cla: yes label Apr 18, 2018

Fix stray path specifiers.

4fce025

bicknellr and others added 14 commits April 17, 2018 18:40

Update paths in test files.

ba09f0b

Update wct-browser-legacy

6e05d99

Add npm description & repository

034c12c

Update webcomponentsjs version

6cc6667

Add the Polymer CLI as devdepency

fecc150

Restore index.html relative paths

e20dddb

Remove ESLint to simplify (also the actual deps are not updated)

8b6957a

remove eslint

Update LICENSE as GitHub preview compatible

bc77f33

Merge PolymerElement & html import

dd23723

Update licenses

50cfeb9

license

Sort imports

ed94a59

xxx xxxx

Indent html content

766f791

Add src to polymer.json sources

4178618

Remove Polymer CLI from Travis

e231817

abdonrd reviewed Apr 18, 2018

View reviewed changes

Merge pull request #1097 from Polymer/polymer-3-more-updates

eea9e41

Polymer 3 project update

googlebot added cla: no and removed cla: yes labels Apr 18, 2018

abdonrd added cla: yes and removed cla: no labels Apr 18, 2018

bicknellr changed the title ~~Add LICENSE file; use name specifiers; remove bower.json~~ Updates for Polymer 3 Apr 18, 2018

keanulee suggested changes Apr 18, 2018

View reviewed changes

Remove LICENSE file: the correct license is referenced by comments at…

689a3de

… the top of files.

googlebot added cla: no and removed cla: yes labels Apr 18, 2018

notwaldorf suggested changes Apr 19, 2018

View reviewed changes

keanulee approved these changes Apr 19, 2018

View reviewed changes

bicknellr commented Apr 19, 2018

View reviewed changes

bicknellr added 3 commits April 19, 2018 16:47

Remove static is getters.

cb6a684

Revert date changes in license comments.

2464a8c

Update polymer-cli.

4837776

abdonrd approved these changes Apr 20, 2018

View reviewed changes

notwaldorf approved these changes Apr 20, 2018

View reviewed changes

bicknellr added cla: yes and removed cla: no labels Apr 20, 2018

Revert sources change in polymer.json.

974b67e

googlebot added cla: no and removed cla: yes labels Apr 21, 2018

Update package-lock.json.

44bccb4

bicknellr added cla: yes and removed cla: no labels Apr 21, 2018

bicknellr merged commit 44bccb4 into 3.0-preview Apr 21, 2018

bicknellr deleted the polymer-3-updates branch April 21, 2018 01:02

		setPassiveTouchGestures(true);

		setRootPath(Polymer.rootPath);

Updates for Polymer 3 #1096

Updates for Polymer 3 #1096

Conversation

bicknellr commented Apr 18, 2018 • edited Loading

bicknellr commented Apr 18, 2018

abdonrd left a comment

Choose a reason for hiding this comment

googlebot commented Apr 18, 2018

googlebot commented Apr 18, 2018

googlebot commented Apr 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

googlebot commented Apr 18, 2018

Choose a reason for hiding this comment

abdonrd Apr 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abdonrd Apr 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

googlebot commented Apr 20, 2018

bicknellr commented Apr 20, 2018 • edited Loading

googlebot commented Apr 21, 2018

bicknellr commented Apr 21, 2018

googlebot commented Apr 21, 2018

bicknellr commented Apr 18, 2018 •

edited

Loading

abdonrd Apr 19, 2018 •

edited

Loading

abdonrd Apr 19, 2018 •

edited

Loading

bicknellr commented Apr 20, 2018 •

edited

Loading