Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy-data-mixin: not applied to TemplatizerInstances #5422

Closed
kevinpschaaf opened this issue Nov 2, 2018 · 0 comments
Closed

legacy-data-mixin: not applied to TemplatizerInstances #5422

kevinpschaaf opened this issue Nov 2, 2018 · 0 comments

Comments

@kevinpschaaf
Copy link
Member

Description

When using the legacy-data-mixin.html to assist in identifying observers/computed functions that may need additional undefined checks due to changes in the undefined rule when porting from 1.x to 2.x, the mixin does not apply to TemplatizerInstaces created by dom-if and dom-repeat. As such, computed bindings in those nested templates will not properly warn on undefined arguments.

Note that this was fixed in the 2.x branch as noted here, and just needs porting to the 3.x branch.

Live Demo

See repross in #5266 (comment).

Browsers Affected

All

Versions

  • Polymer: v3.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant