Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid cost of setting display:none under legacyOptimizations #5541

Closed
kevinpschaaf opened this issue May 17, 2019 · 0 comments · Fixed by #5542
Closed

Avoid cost of setting display:none under legacyOptimizations #5541

kevinpschaaf opened this issue May 17, 2019 · 0 comments · Fixed by #5542

Comments

@kevinpschaaf
Copy link
Member

Description

#4821 addressed the fact that <dom-repeat> and <dom-if> elements can participate in e.g. flexbox and other selectors inadvertently, which was a change from Polymer 1.x where these were <template> type extensions, by adding this.style.display = 'none' to the elements' lifecycle. Although it fixed the issue, it unfortunately has been found to add a measurable tax to element boot-up, particularly on Edge, which is unfortunate if e.g. flexbox issues can otherwise be avoided.

This issue is to only set display: none when not running under the legacyOptimizations flag, as a way to opt-out of the correct behavior to optimize for performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant