Small refactoring in effect metadata #4782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this PR grew big over time, I am factoring out some of the sub-changes. This makes reviewing easier and make sure that the changes are not all-or-nothing, but pick those that we like. I extracted the |
|
Since there are potentially breaking changes in this PR, we are likely to consider it for Polymer 3.x. |
|
Closing the PR for now, but keeping the branch alive. We will revisit this for Polymer 3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor effect metadata system with a couple of modifications:
property-effects. This is primarily a readibility improvement.findTemplateNodeto operate on an array instead of nested objects. This stores significantly less information in a compressed format.Reference Issue
These are preparations #4137