Fail travis on non updated files #5003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is expected to fail, as the library code has been modified, but the task was explicitly not run and files are not added.
This commit is supposed to succeed passed the before_script stage on Travis
aomarks
approved these changes
Dec 21, 2017
dfreedm
requested changes
Jan 8, 2018
.travis.yml
Outdated
| @@ -12,6 +12,8 @@ before_script: | |||
| - npm install -g bower gulp-cli@1 | |||
| - bower install | |||
| - gulp lint-eslint | |||
| - gulp generate-typescript | |||
There was a problem hiding this comment.
Done 👍 Edited on GitHub, so let's see if Travis complains
dfreedm
approved these changes
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4928 we added support for TypeScript by auto-generating types based on the Closure types defined in the library. However, we have to remember that whenever we update our types, that we also regenerate these TypeScript types.
I browsed the man pages of
git diffand came acrossgit diff --exit-code: https://git-scm.com/docs/git-diff#git-diff---exit-code This makesgit difffail whenever there are changes.As such, this PR introduces the
git diffin thebefore_scriptstage on Travis. This task now runs the generation script of TypeScript types and then verifies that there are no uncommitted changes. Whenever someone updates any Closure types (or adds them with new features), the Travis build will now fail if the developer forgot to update the TypeScript types.In the commit history of this PR, you can see that the 2nd commit intentionally failed, by updating 1 of our types and not committing the corresponding TypeScript
d.tsupdates.