Legacy warnings 3.x #5474
Merged
Legacy warnings 3.x #5474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpschaaf
requested review from
dfreedm,
sorvell and
TimvdLippe
as code owners
sorvell
suggested changes
Feb 1, 2019
lib/mixins/property-effects.js
Outdated
| @@ -2390,6 +2390,9 @@ export const PropertyEffects = dedupingMixin(superClass => { | |||
| * @protected | |||
| */ | |||
| static _addTemplatePropertyEffect(templateInfo, prop, effect) { | |||
| if (legacyOptimizations && !(prop in templateInfo.dynamicFns)) { | |||
| console.warn(`Property '${prop}' used in template but not declared in 'properties'.`); | |||
There was a problem hiding this comment.
Suggested change
| console.warn(`Property '${prop}' used in template but not declared in 'properties'.`); | |
| console.warn(`Property '${prop}' used in template but not declared in 'properties'. Setting an attribute will not set the corresponding property unless the property is declared in 'properties'.`; |
sorvell
suggested changes
Feb 4, 2019
sorvell
approved these changes
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds warnings for a couple of subtle changes in behavior between 1.x and 2.x:
legacyOptimizationsflag is enabled). Fixes Add warning for undeclared property in template binding #5473Reference Issue
Fixes #5473 and #5468.