This repository has been archived by the owner on Feb 9, 2023. It is now read-only.
Add unregisterMissingServiceWorkers option. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aomarks
changed the title
unregisterMissingServiceWorkers option.
aomarks
force-pushed
the
sw-killer
branch
3 times, most recently
from
1be9a8c
to
8ee5651
Compare
frankiefu
suggested changes
Oct 23, 2017
src/prpl.ts
Outdated
| @@ -51,6 +67,8 @@ export function makeHandler(root?: string, config?: Config): ( | |||
| console.info(`Serving files from "${absRoot}".`); | |||
| const builds = loadBuilds(absRoot, config); | |||
| const cacheControl = (config && config.cacheControl) || 'max-age=60'; | |||
| const unregisterMissingServiceWorkers = | |||
| (config && config.unregisterMissingServiceWorkers === false) || true; | |||
There was a problem hiding this comment.
Looks like unregisterMissingServiceWorkers is always evaluated to true here.
There was a problem hiding this comment.
Oops! Fixed and added test.
frankiefu
approved these changes
Oct 23, 2017
By default, automatically serve a tiny self-unregistering service worker for would-be 404 service worker requests, to prevent clients from getting stuck with invalid service workers indefinitely.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, automatically serve a tiny self-unregistering service worker for would-be 404 service worker requests, to prevent clients from getting stuck with invalid service workers indefinitely.
Fixes Polymer/shop#150