Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings found by the new linter #114

Closed
wants to merge 5 commits into from
Closed

Fix warnings found by the new linter #114

wants to merge 5 commits into from

Commits on May 11, 2017

  1. Fix all lint warnings. 

    Found one maybe-legit bug where we were setting the name property instead of the name attribute in an iron-selector with attr-for-selected.

Found a few more places where there were missing imports.

And finally, found a few places where the analyzer or a lint rule got confused. Filed bugs or sent PRs for all those.
    @rictic
    rictic committed May 11, 2017
    Configuration menu
    Copy the full SHA
    6e2470a View commit details
    Browse the repository at this point in the history

  2. Use real lazy-imports.

    @rictic
    rictic committed May 11, 2017
    Configuration menu
    Copy the full SHA
    d1d086f View commit details
    Browse the repository at this point in the history

  3. Address review comments.

    @rictic
    rictic committed May 11, 2017
    Configuration menu
    Copy the full SHA
    a567c47 View commit details
    Browse the repository at this point in the history

  4. Unify my TODO comments, pointing at linter bug.

    @rictic
    rictic committed May 11, 2017
    Configuration menu
    Copy the full SHA
    b92e96a View commit details
    Browse the repository at this point in the history

  5. Add a couple more comments.

    @rictic
    rictic committed May 11, 2017
    Configuration menu
    Copy the full SHA
    221d8c8 View commit details
    Browse the repository at this point in the history