Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.0 #193

Merged
merged 42 commits into from
Sep 13, 2018
Merged

3.0 #193

merged 42 commits into from
Sep 13, 2018

Conversation

keanulee
Copy link
Contributor

notwaldorf and others added 30 commits October 4, 2017 13:25
@notwaldorf
run modulizer
fb5d84a
@notwaldorf
fix paths
8b76650
@notwaldorf
fix lazy-resources.html
c6eb16c
@notwaldorf
fix shop-list.js
f4a52f0
@notwaldorf
fix shop-cart
662e2ec
@notwaldorf
fix shop-checkout
4d9e663
@notwaldorf
fix shop-detail
979db65
@keanulee
Static import() paths
4284360
@keanulee
Update @Polymer deps
89a13ad
@ontouchstart
add yarn.lock
128abd2
@ontouchstart
update to Polymer 3.0.0-pre.12
7382a31 
Based on https://www.polymer-project.org/blog/2018-03-23-polymer-3-latest-preview.html

and code in

PolymerLabs/start-polymer3@14bf68a
@ontouchstart
fix shop-checkout.js: Element -> PolymerElement
ee74df3
@keanulee
Merge pull request #173 from ontouchstart/polymer3
9f62d56 
Polymer3
@keanulee
Fix shop-cart-item
204f144
@keanulee
Relative paths for prpl-server
0e0d741
@keanulee
Fix tabs
dc40326
@keanulee
Remove yarn.lock
faf298e
@keanulee
Force to work with polymer-cli and prpl-server
73b982c
@keanulee
Don't need to specify specific fragments
91dd839
@keanulee
Add serve npm script
76c0f1b
@keanulee
Add custom push-manifest
3e25948
@keanulee
autoBasePath; fix 404
f8c960d
@keanulee
Check if iron-form has lazy-loaded yet
d98c202
@keanulee
Move App Engine prpl-server config to server/
649aa9e
@keanulee
Use renamer and replace
ba895bd
@keanulee
Add serve:* scripts
40aed14
@keanulee
Update tools/deps
10fe2a3
@keanulee
Create template instead of div for style modules
639f9dc
@keanulee
Update to wcjs@beta.2
87cc9c5
@keanulee
Update polymer, elements, and cli
85aba32
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

frankiefu
frankiefu approved these changes Sep 13, 2018
View reviewed changes
Copy link
Member

@frankiefu frankiefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay 🎉

@keanulee keanulee merged commit 75dfe58 into master Sep 13, 2018
@keanulee keanulee deleted the 3.0 branch September 13, 2018 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankiefu frankiefu frankiefu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@keanulee @googlebot @frankiefu @notwaldorf @ontouchstart @rictic