Skip to content

Commit

Permalink
Temporary blacklist of firefox >46 (#36)
Browse files Browse the repository at this point in the history
  • Loading branch information
rictic authored and usergenic committed Jun 6, 2018
1 parent 95ecd31 commit 500d101
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion packages/wct-local/src/browsers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,10 @@ export let detect = async function detect(): Promise<{[browser: string]: wd.Capa
for (const browser of browsers) {
if (!LAUNCHPAD_TO_SELENIUM[browser.name]) continue;
const converter = LAUNCHPAD_TO_SELENIUM[browser.name];
results[browser.name] = converter(browser);
const convertedBrowser = converter(browser);
if (convertedBrowser) {
results[browser.name] = convertedBrowser;
}
}

return results;
Expand Down Expand Up @@ -122,6 +125,10 @@ function chrome(browser: launchpad.Browser): wd.Capabilities {
* @return A selenium capabilities object.
*/
function firefox(browser: launchpad.Browser): wd.Capabilities {
const version = browser.version.match(/\d+/)[0];
if (parseInt(version, 10) > 46) {
return null;
}
return {
'browserName': 'firefox',
'version': browser.version.match(/\d+/)[0],
Expand Down

0 comments on commit 500d101

Please sign in to comment.