Merge pull request #166 from Polymer/shared-tslint

Use a single shared top-level tslint

packages/analyzer/src/core/analyzer.ts

@@ -64,7 +64,7 @@ export interface AnalyzeOptions {
  */
 export interface ForkOptions { urlLoader?: UrlLoader; }
 
-export class NoKnownParserError extends Error {};
+export class NoKnownParserError extends Error {}
 
 export type ScannerTable = Map<string, Scanner<ParsedDocument, {}, {}>[]>;
 export type LazyEdgeMap = Map<ResolvedUrl, PackageRelativeUrl[]>;

packages/analyzer/src/css/css-custom-property-scanner.ts

@@ -129,4 +129,4 @@ function* findAllMatchesInString(regex: RegExp, haystack: string) {
   while (match = regex.exec(haystack)) {
     yield {offset: match.index, matched: match[0]};
   }
-};
+}

packages/analyzer/src/demo/polymer-lint.ts

@@ -28,7 +28,7 @@ async function main() {
   if (worstSeverity === Severity.ERROR) {
     process.exit(1);
   }
-};
+}
 
 async function getWarnings(
     analyzer: Analyzer, localPath: string): Promise<Warning[]> {

packages/analyzer/src/javascript/function-scanner.ts

@@ -114,7 +114,7 @@ class FunctionVisitor implements Visitor {
       docNode?: babel.Node) {
     if (docNode === undefined) {
       docNode = node;
-    };
+    }
     const docs = jsdoc.parseJsdoc(getAttachedComment(docNode) || '');
 
     // The @function annotation can override the name.

packages/analyzer/src/javascript/resolve-specifier-node.ts

@@ -82,8 +82,9 @@ export const resolve =
         }
       }
 
-      let relativeSpecifierUrl = relative(
-          dirname(effectiveDocumentPath), resolvedSpecifier) as FileRelativeUrl;
+      let relativeSpecifierUrl =
+          relative(dirname(effectiveDocumentPath), resolvedSpecifier) as
+          FileRelativeUrl;
 
       if (isWindows()) {
         // normalize path separators to URL format

packages/analyzer/src/json/json-document.ts

@@ -31,7 +31,7 @@ export class ParsedJsonDocument extends ParsedDocument<Json, Visitor> {
   private _visit(node: Json, visitors: Visitor[]) {
     for (const visitor of visitors) {
       visitor.visit(node);
-    };
+    }
     if (Array.isArray(node)) {
       for (const value of node) {
         this._visit(value, visitors);

packages/analyzer/src/model/inline-document.ts

@@ -43,7 +43,7 @@ export interface HtmlAstNode {
   node: dom5.Node;
   containingDocument: ParsedHtmlDocument;
 }
-;
+
 
 export interface JsAstNode<N extends babel.Node = babel.Node> {
   language: 'js';

packages/analyzer/src/perf/parse-all-benchmark.ts

@@ -126,7 +126,7 @@ async function measure() {
         `\n==========================================\n\n`);
     process.exit(1);
   }
-};
+}
 
 function printMeasurements(measurements: number[]) {
   console.log(`\n\n\n\n

packages/analyzer/src/polymer/analyze-properties.ts

@@ -171,4 +171,4 @@ export function analyzeProperties(
     analyzedProps.push(prop);
   }
   return analyzedProps;
-};
+}

packages/analyzer/src/polymer/js-utils.ts

@@ -71,4 +71,4 @@ export function toScannedPolymerProperty(
   };
 
   return result;
-};
+}

packages/analyzer/src/scanning/scan.ts

@@ -69,7 +69,7 @@ scan<AstNode, Visitor, PDoc extends ParsedDocument<AstNode, Visitor>>(
       // Let `scan` continue after calls to visit().then()
       currentDoneCallback();
     }
-  };
+  }
 
   // The callback passed to `scan()`
   function visit(visitor: Visitor) {
@@ -81,7 +81,7 @@ scan<AstNode, Visitor, PDoc extends ParsedDocument<AstNode, Visitor>>(
       });
     }
     return visitorsPromise;
-  };
+  }
 
   // Ok, go!
   setup();

packages/analyzer/src/test/core/analyzer_test.ts

@@ -68,7 +68,7 @@ suite('Analyzer', () => {
       throw new Error(`Could not get document for url: ${url}`);
     }
     return result.value;
-  };
+  }
 
   setup(() => {
     const underlyingUrlLoader = new FsUrlLoader(testDir);
@@ -1366,4 +1366,4 @@ var DuplicateNamespace = {};
 
 async function getContext(analyzer: Analyzer) {
   return await analyzer['_analysisComplete'];
-};
+}

packages/analyzer/src/test/core/dependency-graph_test.ts

@@ -78,7 +78,7 @@ suite('DependencyGraph', () => {
       assertStringSetsEqual(
           graph.getAllDependantsOf(analyzer.resolveUrl(path)!),
           expectedDependants.map((u) => analyzer.resolveUrl(u)!));
-    };
+    }
 
     test('works with a basic document with no dependencies', async () => {
       await analyzer.analyze(['dependencies/leaf.html']);

packages/analyzer/src/test/javascript/class-scanner_test.ts

@@ -25,18 +25,18 @@ suite('Class', async () => {
   async function getScannedFeatures(filename: string) {
     const {features} = await runScanner(analyzer, new ClassScanner(), filename);
     return features;
-  };
+  }
 
   async function getScannedClasses(filename: string): Promise<ScannedClass[]> {
     const features = await getScannedFeatures(filename);
     return features.filter((e) => e instanceof ScannedClass) as ScannedClass[];
-  };
+  }
 
   async function getClasses(filename: string) {
     const analysis = await analyzer.analyze([filename]);
     const classes = Array.from(analysis.getFeatures({kind: 'class'}));
     return {classes, analysis};
-  };
+  }
 
   async function getTestProps(class_: ScannedClass|Class) {
     type TestPropsType = {
@@ -105,7 +105,7 @@ suite('Class', async () => {
       result.superClass = class_.superClass.identifier;
     }
     return result;
-  };
+  }
 
   suite('scanning', () => {
     test('finds classes and their names and comment blocks', async () => {

packages/analyzer/src/test/javascript/function-scanner_test.ts

@@ -34,7 +34,7 @@ suite('FunctionScanner', async () => {
       }
     }
     return scannedFunctions;
-  };
+  }
 
 
   async function getTestProps(fn: ScannedFunction): Promise<any> {

packages/analyzer/src/test/javascript/namespace-scanner_test.ts

@@ -34,7 +34,7 @@ suite('NamespaceScanner', async () => {
       }
     }
     return scannedNamespaces;
-  };
+  }
 
   function getProperties(namespace: ScannedNamespace) {
     return [...namespace.properties.values()].map((prop) => {

packages/analyzer/src/test/javascript/resolve-specifier-node_test.ts

@@ -45,50 +45,49 @@ const scopedRootComponentInfo = {
   componentDir
 };
 
-suite('resolve', async() => {
-
-  test('non-component root to shallow dep', async() => {
+suite('resolve', async () => {
+  test('non-component root to shallow dep', async () => {
     assert.equal(
         resolve('shallow', rootMain), './node_modules/shallow/shallow.js');
   });
 
-  test('non-component root to scoped dep', async() => {
+  test('non-component root to scoped dep', async () => {
     assert.equal(
         resolve('@scope/scoped', rootMain),
         './node_modules/@scope/scoped/scoped.js');
   });
 
-  test('shallow dep to scoped dep', async() => {
+  test('shallow dep to scoped dep', async () => {
     assert.equal(
         resolve('@scope/scoped', shallowDepMain, shallowRootComponentInfo),
         '../@scope/scoped/scoped.js');
   });
 
-  test('scoped dep to shallow dep', async() => {
+  test('scoped dep to shallow dep', async () => {
     assert.equal(
         resolve('shallow', scopedDepMain, shallowRootComponentInfo),
         '../../shallow/shallow.js');
   });
 
-  test('component-root to shallow dep', async() => {
+  test('component-root to shallow dep', async () => {
     assert.equal(
         resolve('shallow', rootMain, shallowRootComponentInfo),
         '../shallow/shallow.js');
   });
 
-  test('component-root to scoped dep', async() => {
+  test('component-root to scoped dep', async () => {
     assert.equal(
         resolve('@scope/scoped', rootMain, shallowRootComponentInfo),
         '../@scope/scoped/scoped.js');
   });
 
-  test('scoped-component-root to shallow dep', async() => {
+  test('scoped-component-root to shallow dep', async () => {
     assert.equal(
         resolve('shallow', rootMain, scopedRootComponentInfo),
         '../../shallow/shallow.js');
   });
 
-  test('scoped-component-root to scoped dep', async() => {
+  test('scoped-component-root to scoped dep', async () => {
     assert.equal(
         resolve('@scope/scoped', rootMain, scopedRootComponentInfo),
         '../scoped/scoped.js');

packages/analyzer/src/test/model/warning_test.ts

@@ -46,7 +46,7 @@ suite('applyEdits', () => {
       },
       replacementText
     };
-  };
+  }
 
   test('works in the trivial case', async () => {
     const contents = 'abc';

packages/analyzer/src/test/polymer/polymer-element-old-jsdoc_test.ts

@@ -39,7 +39,7 @@ suite('PolymerElement with old jsdoc annotations', () => {
     }
     const elements = result.value.getFeatures({kind: 'polymer-element'});
     return elements;
-  };
+  }
 
   function getTestProps(element: PolymerElement): any {
     return {

packages/analyzer/src/test/polymer/polymer-element_test.ts

@@ -32,7 +32,7 @@ suite('PolymerElement', async () => {
     const document = result.value;
     const elements = document.getFeatures({kind: 'polymer-element'});
     return elements;
-  };
+  }
 
   function getTestProps(element: PolymerElement): any {
     return {

packages/analyzer/src/test/polymer/polymer2-element-scanner-old-jsdoc_test.ts

@@ -31,7 +31,7 @@ suite('Polymer2ElementScanner with old jsdoc annotations', async () => {
     const {features} = await runScanner(analyzer, new ClassScanner(), filename);
     return features.filter((e) => e instanceof ScannedPolymerElement) as
         ScannedPolymerElement[];
-  };
+  }
 
   async function getTestProps(element: ScannedPolymerElement): Promise<any> {
     const props: any = {

packages/analyzer/src/test/polymer/polymer2-element-scanner_test.ts

@@ -33,7 +33,7 @@ suite('Polymer2ElementScanner', async () => {
 
     return features.filter((e) => e instanceof ScannedPolymerElement) as
         ScannedPolymerElement[];
-  };
+  }
 
   async function getTestProps(element: ScannedPolymerElement): Promise<any> {
     const props: any = {

packages/analyzer/src/test/polymer/polymer2-mixin-scanner-old-jsdoc_test.ts

@@ -28,12 +28,12 @@ suite('Polymer2MixinScanner with old jsdoc annotations', async () => {
     const {features} = await runScanner(analyzer, new ClassScanner(), filename);
     return <ScannedPolymerElementMixin[]>features.filter(
         (e) => e instanceof ScannedPolymerElementMixin);
-  };
+  }
 
   async function getMixins(filename: string) {
     const analysis = await analyzer.analyze([filename]);
     return Array.from(analysis.getFeatures({kind: 'polymer-element-mixin'}));
-  };
+  }
 
   async function getTestProps(mixin: ScannedPolymerElementMixin|
                               PolymerElementMixin) {

packages/analyzer/src/test/polymer/polymer2-mixin-scanner_test.ts

@@ -28,12 +28,12 @@ suite('Polymer2MixinScanner', async () => {
     const {features} = await runScanner(analyzer, new ClassScanner(), filename);
     return <ScannedPolymerElementMixin[]>features.filter(
         (e) => e instanceof ScannedPolymerElementMixin);
-  };
+  }
 
   async function getMixins(filename: string) {
     const analysis = await analyzer.analyze([filename]);
     return Array.from(analysis.getFeatures({kind: 'polymer-element-mixin'}));
-  };
+  }
 
   async function getTestProps(mixin: ScannedPolymerElementMixin|
                               PolymerElementMixin) {

packages/analyzer/tslint.json

@@ -1,60 +1,3 @@
 {
-    "rules": {
-        "arrow-parens": true,
-        "class-name": true,
-        "indent": [
-            true,
-            "spaces"
-        ],
-        "prefer-const": true,
-        "no-duplicate-variable": true,
-        "no-eval": true,
-        "no-internal-module": true,
-        "no-trailing-whitespace": true,
-        "no-var-keyword": true,
-        "one-line": [
-            true,
-            "check-open-brace",
-            "check-whitespace"
-        ],
-        "quotemark": [
-            true,
-            "single",
-            "avoid-escape"
-        ],
-        "semicolon": [
-            true,
-            "always"
-        ],
-        "trailing-comma": [
-            true,
-            "multiline"
-        ],
-        "triple-equals": [
-            true,
-            "allow-null-check"
-        ],
-        "typedef-whitespace": [
-            true,
-            {
-                "call-signature": "nospace",
-                "index-signature": "nospace",
-                "parameter": "nospace",
-                "property-declaration": "nospace",
-                "variable-declaration": "nospace"
-            }
-        ],
-        "variable-name": [
-            true,
-            "ban-keywords"
-        ],
-        "whitespace": [
-            true,
-            "check-branch",
-            "check-decl",
-            "check-operator",
-            "check-separator",
-            "check-type"
-        ]
-    }
+    "extends": "../../tslint.json"
 }

packages/browser-capabilities/src/browser-capabilities.ts

@@ -103,7 +103,7 @@ export function browserCapabilities(userAgent: string): Set<BrowserCapability> {
     if (predicates[capability](ua)) {
       capabilities.add(capability);
     }
-  };
+  }
   return capabilities;
 }
 

packages/browser-capabilities/tslint.json

@@ -0,0 +1,3 @@
+{
+  "extends": "../../tslint.json"
+}

packages/build/src/html-splitter.ts

@@ -98,7 +98,7 @@ export function scriptWasSplitByHtmlSplitter(script: dom5.Node): boolean {
 export type HtmlSplitterFile = File&{
   fromHtmlSplitter?: true;
   moduleScriptIdx?: number
-}
+};
 
 /**
  * Return whether the given Vinyl file was created by the HtmlSplitter from an